feat!: use gradient method for the optimisation part #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us avancée que Nelder Mead, demo.py est la version python de demo.ipynb dans laquelle a été ajoutée la classe class MaxEntropyEnrichment_gradient:
…outjours le même lagrangien
…radient puis mis en commentaire car cela ne changeait pas grand chose
…us avancée que Nelder Mead, demo.py est la version python de demo.ipynb dans laquelle a été ajoutée la classe class MaxEntropyEnrichment_gradient:
…outjours le même lagrangien
…radient puis mis en commentaire car cela ne changeait pas grand chose
# Conflicts: # bhepop2/gradient_enrich.py # examples/demo.ipynb
leo-desbureaux-tellae
changed the title
leo-desbureaux-tellae
force-pushed
the
gradient
branch
from
36bbdcc to
238e97a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We change the optimisation algorithm (computation of crossed modalities probabilities) for a self implemented one, in order to get rid of the maxentropy package which is no longer maintained. Enrichment classes are given more consistent name.
The global quality of the resulting population is improved by this new implementation (better fit to the marginal distributions).
Former modules, classes and tests are kept in this commit to provide a comparison environment if needed. They will be removed later.
CAUTION : these changes introduced a problem where the test_bhepop2_enrich test would pass locally but not on github. See #34
BREAKING CHANGE:
Close: #28