Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap v1.0.0 #40

Closed
7 of 8 tasks
leo-desbureaux-tellae opened this issue Dec 18, 2023 · 1 comment
Closed
7 of 8 tasks

Roadmap v1.0.0 #40

leo-desbureaux-tellae opened this issue Dec 18, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@leo-desbureaux-tellae
Copy link
Contributor

leo-desbureaux-tellae commented Dec 18, 2023

  • Merge "qualitative enrichment" feature: manage analysis for qualitative features, cleanup code, example (qualitative squash #39)
  • Refactoring of enrichment classes: create a parent class that can be inherited to implement other enrichment methods (e.g uniform) (Improve code #17)
  • Improve testing: add more unit tests, less macro tests. Evaluate macro tests on aggregated results instead of exact comparison with a stored table.
  • Expose analysis methods in enrichment classes (allows easier calls with class params) (Modality specification in analysis functions #36) (Improve plots generation #19)
  • Create "accessibility" methods: avoids creating the class, calling optimize and assign_feature_value_to_pop. Facilitates exterior use. Try to answer the question how do we want to call the bhepop2 library (in Eqasim for instance) ([EQASIM/BHEPOP2] Utilisation du package bhepop2 dans EQASIM #26)
  • Improve/complete documentation, adapt to qualitative approach: maybe explain the package on a qualitative example, simpler (Improve documentation #21)
  • Improve example notebooks (rename with distribution type quantitative/qualitative), make them simpler, lighter
  • Have a single, smaller synthetic population for examples and tests. For distributions, we have one real life data set (Filosofi) and a distribution that comes from a population, then used to re-enrich this population. Heavy and realistic VS no distribution data and almost meaningless.
@leo-desbureaux-tellae leo-desbureaux-tellae added the enhancement New feature or request label Dec 18, 2023
@leo-desbureaux-tellae
Copy link
Contributor Author

Most of these changes are resolved in #42

Comments:

  • More refactoring may be needed (Distributions could be refactored into classes #41)
  • Accessibility methods seem less relevant with the new class systems. The double call has been removed, but some more initialisation is needed.
  • Documentation still be improved (as always), but some work has been done
  • Notebooks have been adapted, but not really improved. They do the work. The qualitative notebook may need a cleanup
  • Last point (single, small synthetic population) has not been adressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant