Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modality specification in analysis functions #36

Closed
leo-desbureaux-tellae opened this issue Oct 23, 2023 · 1 comment · Fixed by #42
Closed

Modality specification in analysis functions #36

leo-desbureaux-tellae opened this issue Oct 23, 2023 · 1 comment · Fixed by #42
Labels
enhancement New feature or request

Comments

@leo-desbureaux-tellae
Copy link
Contributor

When performing an analysis of the enrichment results (for instance using analyse_enriched_populations) , we provide a dict of modalities.

This is not consistent with the enrichment classes taking a list of attributes and inferring the modalities from the distributions.
In the other hand, this allows performing the analysis on a subset of modalities.

We should allow specifying a subset of modalities, but the complete set should be defined as in the enrichment classes.

This highlights some preprocessing duplication between enrichment and analysis. One way to avoid such duplication and ensure parameters consistency would be to call analysis from the enrichment class.

@leo-desbureaux-tellae leo-desbureaux-tellae added the enhancement New feature or request label Oct 23, 2023
@leo-desbureaux-tellae leo-desbureaux-tellae changed the title Modality specification Modality specification in analysis functions Oct 23, 2023
@PierreOlivierVandanjon
Copy link
Collaborator

But if analyse_enriched_population is independent from the enrichment class, it can be used to analyze other solutions. For example, in our papers, we compare our solutions with solutions easier to compute in order to show the interest and the limit of the proposed methodology. To be discussed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants