This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Fix prompter #877
Merged
Fix prompter #877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosen-vladimirov
approved these changes
Jan 18, 2017
|
💔 |
After removing the fibers we forgot to await the result from the prompt before calling the unmuteStdout method. After this method is invoked the input from the terminal is not accepted.
TsvetanMilanov
force-pushed
the
milanov/fix-prompter
branch
from
d10b273 to
55b7dfd
Compare
|
❤️ |
TsvetanMilanov
added a commit
to NativeScript/nativescript-cli
that referenced
this pull request
Jan 18, 2017
After removing the fibers we forgot to await the result from the prompt before calling the unmuteStdout method. After this method is invoked the input from the terminal is not accepted. Common lib reference: telerik/mobile-cli-lib#877
TsvetanMilanov
added a commit
to NativeScript/nativescript-cli
that referenced
this pull request
Jan 18, 2017
After removing the fibers we forgot to await the result from the prompt before calling the unmuteStdout method. After this method is invoked the input from the terminal is not accepted. Common lib reference: telerik/mobile-cli-lib#877
TsvetanMilanov
added a commit
to NativeScript/nativescript-cli
that referenced
this pull request
Jan 18, 2017
After removing the fibers we forgot to await the result from the prompt before calling the unmuteStdout method. After this method is invoked the input from the terminal is not accepted. Common lib reference: telerik/mobile-cli-lib#877
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After removing the fibers we forgot to await the result from the prompt before calling the unmuteStdout method. After this method is invoked the input from the terminal is not accepted.