This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Transpile to ES6 #843
Merged
Transpile to ES6 #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Collaborator
Author
|
run ci |
|
❤️ |
rosen-vladimirov
force-pushed
the
vladimirov/es6
branch
from
00e08ef to
3925c26
Compare
|
❤️ |
queue.ts
Outdated
|
|
||
| public constructor(private items: T[] = []) { | ||
| public constructor(private items?: T[]) { | ||
| items = items === undefined ? [] : items; |
| const pathToIstanbul = path.join(__dirname, "..", "node_modules", "istanbul", "lib", "cli.js"); | ||
| const pathToMocha = path.join(__dirname, "..", "node_modules", "mocha", "bin", "_mocha"); | ||
|
|
||
| const istanbulArgs = [ pathToIstanbul, "cover", pathToMocha ]; |
Contributor
There was a problem hiding this comment.
Do we need the extra spaces after [ and before ]?
Collaborator
Author
There was a problem hiding this comment.
I feel more comfortable this way 😃
test-scripts/istanbul.js
Outdated
|
|
||
| const args = nodeArgs.concat(istanbulArgs); | ||
|
|
||
| const nodeProcess = childProcess.spawn("node", args, { stdio: "inherit"}); |
Contributor
There was a problem hiding this comment.
Add one more space after "inherit" please.
test-scripts/istanbul.js
Outdated
| const childProcess = require("child_process"); | ||
| const path = require("path"); | ||
| const pathToIstanbul = path.join(__dirname, "..", "node_modules", "istanbul", "lib", "cli.js"); | ||
| const pathToMocha = path.join(__dirname, "..", "node_modules", "mocha", "bin", "_mocha"); |
Contributor
There was a problem hiding this comment.
Can you extract the path to node_modules?
test-scripts/mocha.js
Outdated
|
|
||
| const args = nodeArgs.concat(pathToMocha); | ||
|
|
||
| const nodeProcess = childProcess.spawn("node", args, { stdio: "inherit"}); |
Contributor
There was a problem hiding this comment.
Add one more space after "inherit" please.
Also this file does the same as test-scripts/istanbul.js. The only difference is args. I think it will be good to extract the common logic.
This was referenced Nov 30, 2016
rosen-vladimirov
force-pushed
the
vladimirov/es6
branch
from
3925c26 to
3dbaee6
Compare
|
❤️ |
1 similar comment
|
❤️ |
rosen-vladimirov
force-pushed
the
vladimirov/es6
branch
from
7cc5373 to
4dc56d7
Compare
|
❤️ |
rosen-vladimirov
force-pushed
the
vladimirov/es6
branch
from
4dc56d7 to
3360bdc
Compare
|
❤️ |
1 similar comment
|
❤️ |
rosen-vladimirov
force-pushed
the
vladimirov/es6
branch
from
6637f22 to
7a50b1c
Compare
|
❤️ |
TsvetanMilanov
approved these changes
Dec 7, 2016
Add support for ES6 transpilation. Change dependency injection in order to match the `class` and `constructor` keywords. Update istanbul to latest version as its previous versions do not support ES6. Remove bluebird.d.ts as it conflicts with Promises from TypeScript's ES6 d.ts. Remove bluebird as dependency - we will use native Promises from now on. Add support for Node.js 4 and 5 - both versions have limited support for ES6 features, so in order to support them we have to: - pass --harmony flag to Node.js - do not use some features like default values of method arguments. - do not use spread operator - it's implementation in Node.js 4 is limited only to arrays. Even this implementation has issues. So use `.apply` instead of using spread operator. Remove all other usages of spread operator (for objects). Add tests scripts for istanbul and mocha, as they both will need the `--harmony` flag as well, so we cannot execute them directly with Node.js 4 and 5. Instead we'll execute a custom script, that will start a new node process. Fix running hooks We should be able resolve functions with $injector - this is required for hooks execution and generating help content. Get back the old unit tests that were testing this functionality. Move node-args to scripts dir
rosen-vladimirov
force-pushed
the
vladimirov/es6
branch
from
7a50b1c to
28d5fe1
Compare
|
❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ES6 transpilation. Change dependency injection in order to match the
classandconstructorkeywords.Update istanbul to latest version as its previous versions do not support ES6.
Remove bluebird.d.ts as it conflicts with Promises from TypeScript's ES6 d.ts.
Remove bluebird as dependency - we will use native Promises from now on.
Add support for Node.js 4 and 5 - both versions have limited support for ES6 features, so in order to support them we have to:
.applyinstead of using spread operator. Remove all other usages of spread operator (for objects).Add tests scripts for istanbul and mocha, as they both will need the
--harmonyflag as well, so we cannot execute them directly with Node.js 4 and 5. Instead we'll execute a custom script, that will start a new node process.