This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Added install hook. #839
Merged
Added install hook. #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 |
nsndeck
force-pushed
the
nnikolov/InstallHook
branch
from
cca5ef3 to
8b7308a
Compare
hdeshev
suggested changes
Nov 11, 2016
Contributor
hdeshev
left a comment
hdeshev
left a comment
There was a problem hiding this comment.
OK after fixing the $hooksService injects.
|
|
||
| constructor(protected $logger: ILogger) { | ||
| constructor(protected $logger: ILogger, | ||
| protected $hooksService: IHooksService) { |
Contributor
There was a problem hiding this comment.
$hooksService seems unused. Why inject it all over the place?
Contributor
There was a problem hiding this comment.
Turns out the hook decorator needs that. It looks like we need to kill this decorator and move this feature to a method of the hook service (outside of scope for this PR).
|
💔 |
hdeshev
approved these changes
Nov 11, 2016
nsndeck
force-pushed
the
nnikolov/InstallHook
branch
from
8b7308a to
0ea70d9
Compare
|
❤️ |
rosen-vladimirov
approved these changes
Nov 11, 2016
Collaborator
rosen-vladimirov
left a comment
rosen-vladimirov
left a comment
There was a problem hiding this comment.
After fixing comment.
Great work
| $logger: ILogger) { | ||
| super($logger); | ||
| $logger: ILogger, | ||
| $hooksService: IHooksService) { |
Collaborator
There was a problem hiding this comment.
these should be tabs
nsndeck
force-pushed
the
nnikolov/InstallHook
branch
from
0ea70d9 to
259100a
Compare
|
💔 |
Contributor
Author
|
run ci |
|
💔 |
Collaborator
|
run ci |
|
❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be useful for some scenarios like granting permissions for application via adb (automating testing process). Granting permissions require app to be deployed on device in order to work, so after-prepare hook cannot be used.