Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

July kb articles #549

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

July kb articles #549

wants to merge 3 commits into from

Conversation

filipKovachev
Copy link
Contributor

@filipKovachev filipKovachev commented Mar 26, 2024

zdravkov
zdravkov previously approved these changes Mar 27, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting a JS error when running this sample - https://stackblitz.com/edit/2ldtc8-yye6yj?file=src%2Fmain.vue


## Description

This Knowledge base(KB) article demonstrates how we can add a custom validation error for the Upload component.
Copy link
Contributor

@vveesseelliinnaa vveesseelliinnaa Mar 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add sentence explaining when the added custom error will be shown in the demo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sample does not work on Stackblitz for some reason (it is OK in CodeSandBox)

{
Id: 31289,
ApprovalStatus: {
Name: 'Approved by a very log whatnot label here sooo long',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure that the long message does not contain so many typos. E.g., you can change it to
"Approved by a very long, loooong and even longer label shown inside a tooltip"


## Description

How to add a tooltip to the Chart series items?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not clear to me that the tooltip will be shown only when I hover over the labels in the y axis. Can you update the description to state that, so the clients will not expect them over the actual series items of the chart.

@filipKovachev filipKovachev marked this pull request as draft June 5, 2024 22:48
@filipKovachev filipKovachev changed the title March kb articles June kb articles Jun 5, 2024
@filipKovachev filipKovachev changed the title June kb articles July kb articles Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants