Skip to content

Val/988 add mstest4 configuration - #243

Merged
ValentinaPetrova merged 3 commits into
developfrom
val/988-add-mstest4-configuration
Nov 12, 2025
Merged

Val/988 add mstest4 configuration#243
ValentinaPetrova merged 3 commits into
developfrom
val/988-add-mstest4-configuration

Conversation

@ValentinaPetrova

@ValentinaPetrova ValentinaPetrova commented Nov 11, 2025

Copy link
Copy Markdown
Contributor
  • add MSTest4 resolver
  • create a base class for all mstest resolvers
  • add MSTest 4 assembly to TestMethodEmitter.cpp
  • change lock scope in HierarchicalTestFrameworkContextResolver

closes telerik/MATTeam#988

ValentinaPetrova and others added 2 commits November 7, 2025 14:37
 - add MSTestV4MockingContextResolver.cs
 - create a base class for all mstest resolvers

closes #988

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for MSTest version 4 to the JustMock framework by creating a base class abstraction for all MSTest resolvers and introducing a new MSTestV4 resolver. The changes consolidate duplicate code and extend test framework compatibility.

Key Changes:

  • Created a new base class MSTestBaseMockingContextResolver to consolidate common MSTest logic
  • Added MSTestV4MockingContextResolver for MSTest 4 support
  • Optimized lock scope in HierarchicalTestFrameworkContextResolver by moving non-critical operations outside the lock

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
MockingContext.cs Registers the new MSTestV4 resolver
MSTestV4MockingContextResolver.cs New resolver implementation for MSTest 4 framework
MSTestV2MockingContextResolver.cs Refactored to inherit from base class, removing duplicated code
MSTestMockingContextResolver.cs Refactored to inherit from base class, removing duplicated code
MSTestBaseMockingContextResolver.cs New base class containing shared MSTest resolver logic
HierarchicalTestFrameworkContextResolver.cs Lock scope optimization using environment variable flag

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Telerik.JustMock/Core/Context/HierarchicalTestFrameworkContextResolver.cs Outdated
Comment thread Telerik.JustMock/Core/Context/HierarchicalTestFrameworkContextResolver.cs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants