fix: val/994-fix-castlecore-for-net10 - #242
Merged
Merged
Conversation
- return the right object field in Reference method from FieldReference closes #994
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the FieldReference class where property getters were returning incorrect field references. The changes ensure that the FieldBuilder and Reference properties return their corresponding instance fields (fieldBuilder and field respectively) by adding explicit this. qualifiers.
- Fixed
FieldBuilderproperty to returnthis.fieldBuilderinstead of the incorrect reference - Fixed
Referenceproperty to returnthis.fieldinstead of the incorrect reference
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ivo-stoilov
approved these changes
Oct 31, 2025
This was referenced Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: val/994-fix-castlecore-for-net10
closes telerik/MATTeam#994