Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ghcr.io for images and a Minikube or Colima cluster. #3659

Merged
merged 6 commits into from
Aug 11, 2024

Conversation

thallgren
Copy link
Member

@thallgren thallgren commented Aug 5, 2024

This PR uses a Minikube or Colima cluster instead of kubeception. This
removes the need for a special proprietary kubeception token when
running the integration tests, and also opens up for running tests that
require Docker on all platforms.

The PR also changes how images are built and used. Instead of pushing
them a registry in the cluster, the images are pushed to ghcr.io, and
then removed when the workflow ends.

Integration tests on windows are disabled because there's no way to run
a local cluster without nested virtualization. In essence:

  • WSL1 doesn't work because it doesn't provide systemd, and systemd
    requires a real kernel.
  • WSL2 is unable to run because virtualization is unavailable..](942de91)

This PR uses a Minikube or Colima cluster instead of kubeception. This
removes the need for a special proprietary kubeception token when
running the integration tests, and also opens up for running tests that
require Docker on all platforms.

The PR also changes how images are built and used. Instead of pushing
them a registry in the cluster, the images are pushed to ghcr.io, and
then removed when the workflow ends.

Integration tests on windows are disabled because there's no way to run
a local cluster without nested virtualization. In essence:

  • WSL1 doesn't work because it doesn't provide systemd, and systemd
    requires a real kernel.
  • WSL2 is unable to run because virtualization is unavailable.

@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 5, 2024
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 5, 2024
@thallgren thallgren force-pushed the thallgren/rely-on-docker-base branch from d2c3c4b to 948f738 Compare August 5, 2024 09:09
@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 5, 2024
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 5, 2024
@thallgren thallgren force-pushed the thallgren/rely-on-docker-base branch from 948f738 to f1b51ea Compare August 5, 2024 09:15
@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 5, 2024
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 5, 2024
@thallgren thallgren force-pushed the thallgren/rely-on-docker-base branch from f1b51ea to ea383ad Compare August 5, 2024 17:29
@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 5, 2024
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 5, 2024
@thallgren thallgren force-pushed the thallgren/rely-on-docker-base branch from ea383ad to 5cdd4ec Compare August 5, 2024 20:56
@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 5, 2024
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 5, 2024
@thallgren thallgren force-pushed the thallgren/rely-on-docker-base branch from 5cdd4ec to 4e8bfb8 Compare August 6, 2024 06:53
@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 6, 2024
@thallgren thallgren force-pushed the thallgren/rely-on-docker-base branch from 4e8bfb8 to dc7df02 Compare August 6, 2024 08:08
@thallgren thallgren added ok to test Applied by maintainers when a PR is ready to have tests run on it and removed ok to test Applied by maintainers when a PR is ready to have tests run on it labels Aug 6, 2024
@thallgren thallgren force-pushed the thallgren/rely-on-docker-base branch from dc7df02 to 3a2721a Compare August 6, 2024 08:25
@thallgren thallgren added ok to test Applied by maintainers when a PR is ready to have tests run on it and removed ok to test Applied by maintainers when a PR is ready to have tests run on it labels Aug 6, 2024
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 6, 2024
@thallgren thallgren force-pushed the thallgren/rely-on-docker branch 7 times, most recently from 2b47863 to feb5378 Compare August 9, 2024 10:40
@thallgren thallgren force-pushed the thallgren/rely-on-docker-base branch from ee00374 to 24c58f5 Compare August 9, 2024 15:44
@thallgren thallgren added ok to test Applied by maintainers when a PR is ready to have tests run on it and removed ok to test Applied by maintainers when a PR is ready to have tests run on it labels Aug 9, 2024
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 9, 2024
@thallgren thallgren force-pushed the thallgren/rely-on-docker-base branch from 24c58f5 to daeed3c Compare August 9, 2024 21:12
@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 9, 2024
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 9, 2024
@thallgren thallgren force-pushed the thallgren/rely-on-docker-base branch from daeed3c to dd1d6e0 Compare August 10, 2024 06:38
@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 10, 2024
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 10, 2024
This PR uses a Minikube or Colima cluster instead of kubeception. This
removes the need for a special proprietary kubeception token when
running the integration tests, and also opens up for running tests that
require Docker on all platforms.

The PR also changes how images are built and used. Instead of pushing
them a registry in the cluster, the images are pushed to ghcr.io, and
then removed when the workflow ends.

Integration tests on windows are disabled because there's no way to run
a local cluster without nested virtualization. In essence:
 - WSL1 doesn't work because it doesn't provide systemd, and systemd
   requires a real kernel.
 - WSL2 is unable to run because virtualization is unavailable.

Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
@thallgren thallgren force-pushed the thallgren/rely-on-docker-base branch from dd1d6e0 to 942de91 Compare August 10, 2024 14:49
Signed-off-by: Thomas Hallgren <[email protected]>
@thallgren thallgren added the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 10, 2024
@github-actions github-actions bot removed the ok to test Applied by maintainers when a PR is ready to have tests run on it label Aug 10, 2024
@thallgren thallgren changed the base branch from thallgren/rely-on-docker-base to release/v2 August 11, 2024 03:19
@thallgren thallgren changed the title Test CI changes on the rely-on-docker-base branch Use ghcr.io for images and a Minikube or Colima cluster. Aug 11, 2024
@thallgren thallgren merged commit c248380 into release/v2 Aug 11, 2024
12 checks passed
@thallgren thallgren deleted the thallgren/rely-on-docker branch August 11, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant