-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ghcr.io for images and a Minikube or Colima cluster. #3659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thallgren
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 5, 2024
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 5, 2024
thallgren
force-pushed
the
thallgren/rely-on-docker-base
branch
from
August 5, 2024 09:09
d2c3c4b
to
948f738
Compare
thallgren
force-pushed
the
thallgren/rely-on-docker
branch
from
August 5, 2024 09:09
688a92a
to
11f7f06
Compare
thallgren
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 5, 2024
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 5, 2024
thallgren
force-pushed
the
thallgren/rely-on-docker-base
branch
from
August 5, 2024 09:15
948f738
to
f1b51ea
Compare
thallgren
force-pushed
the
thallgren/rely-on-docker
branch
from
August 5, 2024 09:16
11f7f06
to
c9c05a5
Compare
thallgren
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 5, 2024
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 5, 2024
thallgren
force-pushed
the
thallgren/rely-on-docker-base
branch
from
August 5, 2024 17:29
f1b51ea
to
ea383ad
Compare
thallgren
force-pushed
the
thallgren/rely-on-docker
branch
from
August 5, 2024 17:29
c9c05a5
to
76d3d01
Compare
thallgren
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 5, 2024
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 5, 2024
thallgren
force-pushed
the
thallgren/rely-on-docker-base
branch
from
August 5, 2024 20:56
ea383ad
to
5cdd4ec
Compare
thallgren
force-pushed
the
thallgren/rely-on-docker
branch
from
August 5, 2024 20:57
76d3d01
to
4dac27f
Compare
thallgren
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 5, 2024
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 5, 2024
thallgren
force-pushed
the
thallgren/rely-on-docker-base
branch
from
August 6, 2024 06:53
5cdd4ec
to
4e8bfb8
Compare
thallgren
force-pushed
the
thallgren/rely-on-docker
branch
from
August 6, 2024 06:55
4dac27f
to
6c09f05
Compare
thallgren
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 6, 2024
thallgren
force-pushed
the
thallgren/rely-on-docker-base
branch
from
August 6, 2024 08:08
4e8bfb8
to
dc7df02
Compare
thallgren
force-pushed
the
thallgren/rely-on-docker
branch
from
August 6, 2024 08:09
6c09f05
to
b12915b
Compare
thallgren
added
ok to test
Applied by maintainers when a PR is ready to have tests run on it
and removed
ok to test
Applied by maintainers when a PR is ready to have tests run on it
labels
Aug 6, 2024
thallgren
force-pushed
the
thallgren/rely-on-docker-base
branch
from
August 6, 2024 08:25
dc7df02
to
3a2721a
Compare
thallgren
force-pushed
the
thallgren/rely-on-docker
branch
from
August 6, 2024 08:27
b12915b
to
d1b23e8
Compare
thallgren
added
ok to test
Applied by maintainers when a PR is ready to have tests run on it
and removed
ok to test
Applied by maintainers when a PR is ready to have tests run on it
labels
Aug 6, 2024
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 6, 2024
thallgren
force-pushed
the
thallgren/rely-on-docker
branch
7 times, most recently
from
August 9, 2024 10:40
2b47863
to
feb5378
Compare
thallgren
force-pushed
the
thallgren/rely-on-docker-base
branch
from
August 9, 2024 15:44
ee00374
to
24c58f5
Compare
thallgren
force-pushed
the
thallgren/rely-on-docker
branch
from
August 9, 2024 15:46
feb5378
to
da427d4
Compare
thallgren
added
ok to test
Applied by maintainers when a PR is ready to have tests run on it
and removed
ok to test
Applied by maintainers when a PR is ready to have tests run on it
labels
Aug 9, 2024
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 9, 2024
thallgren
force-pushed
the
thallgren/rely-on-docker-base
branch
from
August 9, 2024 21:12
24c58f5
to
daeed3c
Compare
thallgren
force-pushed
the
thallgren/rely-on-docker
branch
from
August 9, 2024 21:12
da427d4
to
dffc53b
Compare
thallgren
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 9, 2024
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 9, 2024
thallgren
force-pushed
the
thallgren/rely-on-docker-base
branch
from
August 10, 2024 06:38
daeed3c
to
dd1d6e0
Compare
thallgren
force-pushed
the
thallgren/rely-on-docker
branch
from
August 10, 2024 06:38
dffc53b
to
a1138a7
Compare
thallgren
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 10, 2024
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 10, 2024
This PR uses a Minikube or Colima cluster instead of kubeception. This removes the need for a special proprietary kubeception token when running the integration tests, and also opens up for running tests that require Docker on all platforms. The PR also changes how images are built and used. Instead of pushing them a registry in the cluster, the images are pushed to ghcr.io, and then removed when the workflow ends. Integration tests on windows are disabled because there's no way to run a local cluster without nested virtualization. In essence: - WSL1 doesn't work because it doesn't provide systemd, and systemd requires a real kernel. - WSL2 is unable to run because virtualization is unavailable. Signed-off-by: Thomas Hallgren <[email protected]> Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
force-pushed
the
thallgren/rely-on-docker-base
branch
from
August 10, 2024 14:49
dd1d6e0
to
942de91
Compare
Signed-off-by: Thomas Hallgren <[email protected]>
thallgren
force-pushed
the
thallgren/rely-on-docker
branch
from
August 10, 2024 14:50
a1138a7
to
138d267
Compare
thallgren
added
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 10, 2024
github-actions
bot
removed
the
ok to test
Applied by maintainers when a PR is ready to have tests run on it
label
Aug 10, 2024
thallgren
changed the base branch from
thallgren/rely-on-docker-base
to
release/v2
August 11, 2024 03:19
thallgren
changed the title
Test CI changes on the rely-on-docker-base branch
Use ghcr.io for images and a Minikube or Colima cluster.
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses a Minikube or Colima cluster instead of kubeception. This
removes the need for a special proprietary kubeception token when
running the integration tests, and also opens up for running tests that
require Docker on all platforms.
The PR also changes how images are built and used. Instead of pushing
them a registry in the cluster, the images are pushed to ghcr.io, and
then removed when the workflow ends.
Integration tests on windows are disabled because there's no way to run
a local cluster without nested virtualization. In essence:
requires a real kernel.
This PR uses a Minikube or Colima cluster instead of kubeception. This
removes the need for a special proprietary kubeception token when
running the integration tests, and also opens up for running tests that
require Docker on all platforms.
The PR also changes how images are built and used. Instead of pushing
them a registry in the cluster, the images are pushed to ghcr.io, and
then removed when the workflow ends.
Integration tests on windows are disabled because there's no way to run
a local cluster without nested virtualization. In essence:
requires a real kernel.