-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for message formatting (-- to −, >> to », << to «) in "Settings" window #4553
Conversation
the travis build failed with |
@@ -296,6 +296,7 @@ https://github.com/telegramdesktop/tdesktop/blob/master/LEGAL | |||
|
|||
"lng_settings_section_chat_settings" = "Chat Settings"; | |||
"lng_settings_replace_emojis" = "Replace emoji"; | |||
"lng_settings_message_formatting" = "Message formatting"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"message formatting" isn't clear enough imo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This strange replacements are made by telegram, not clear enough too :)
I really can't understand for what\whom it's done, and therefore have strong feeling, that this PR will be rejected...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
someone knows how should it be called?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace double chars (<<, >>, --) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or
Double chars (<< >> --) replacement.
Double chars (<< >> --) to special chars.
Convert (<< >> --) to special chars.
Convert (<< >> --) to (« » −).
Replace (<< >> --) with (« » −).
etc...
But, imho, this feature does not deserve an option in settings, and simple must be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stek29 It's clear enough now.
This options allows to toggle off the old behaviour with replacing char sequences like <<, >>, -- to chars, which can be represented by HTML escape characters "«", "»", "—". Based on upstream pull telegramdesktop/tdesktop#4553 and commit PeterMX/tdesktop@fe11883 from @PeterMX Closes #132
This option allows to turn off the old behaviour with replacing char sequences like <<, >>, -- to chars represented by HTML escape characters "«", "»", "—". Based on upstream pull telegramdesktop/tdesktop#4553 and commit PeterMX/tdesktop@fe11883 from @PeterMX Closes #132
This option allows to turn off the old behaviour with replacing char sequences like <<, >>, -- to chars represented by HTML escape characters "«", "»", "—". Based on upstream pull telegramdesktop/tdesktop#4553 and commit PeterMX/tdesktop@fe11883 from @PeterMX Closes #132
See 4b763a7 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
this closes #522 because add an option in settings to disable message formatting, it's enable by default so it's not a problem for people than use it.