Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for message formatting (-- to ‏‎−, >> to », << to «) in "Settings" window #4553

Closed
wants to merge 3 commits into from

Conversation

PeterMX
Copy link

@PeterMX PeterMX commented Mar 30, 2018

this closes #522 because add an option in settings to disable message formatting, it's enable by default so it's not a problem for people than use it.

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2018

CLA assistant check
All committers have signed the CLA.

@PeterMX PeterMX changed the title Option for message formatting (-- to ‏‎−, >> to », << to «) Add option for message formatting (-- to ‏‎−, >> to », << to «) in "Settings" window Mar 30, 2018
@Walkman100
Copy link

the travis build failed with The job exceeded the maximum time limit for jobs, and has been terminated. 😑

@@ -296,6 +296,7 @@ https://github.com/telegramdesktop/tdesktop/blob/master/LEGAL

"lng_settings_section_chat_settings" = "Chat Settings";
"lng_settings_replace_emojis" = "Replace emoji";
"lng_settings_message_formatting" = "Message formatting";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"message formatting" isn't clear enough imo

Copy link
Contributor

@kirsan31 kirsan31 Apr 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This strange replacements are made by telegram, not clear enough too :)
I really can't understand for what\whom it's done, and therefore have strong feeling, that this PR will be rejected...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

someone knows how should it be called?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace double chars (<<, >>, --) ?

Copy link
Contributor

@kirsan31 kirsan31 Apr 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or

Double chars (<< >> --) replacement.
Double chars (<< >> --) to special chars.
Convert (<< >> --) to special chars.
Convert (<< >> --) to (« » −).
Replace (<< >> --) with (« » −).
etc...

But, imho, this feature does not deserve an option in settings, and simple must be removed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stek29 It's clear enough now.

leha-bot added a commit to procxx/kepka that referenced this pull request Apr 18, 2018
This options allows to toggle off the old behaviour with replacing char
sequences like <<, >>, -- to chars, which can be represented by HTML
escape characters "&laquo;", "&raquo;", "&mdash;".

Based on upstream pull
telegramdesktop/tdesktop#4553 and
commit PeterMX/tdesktop@fe11883
from @PeterMX

Closes #132
leha-bot added a commit to procxx/kepka that referenced this pull request Apr 21, 2018
This option allows to turn off the old behaviour with replacing char
sequences like <<, >>, -- to chars represented by HTML escape characters
"&laquo;", "&raquo;", "&mdash;".

Based on upstream pull
telegramdesktop/tdesktop#4553 and commit
PeterMX/tdesktop@fe11883
from @PeterMX

Closes #132
leha-bot added a commit to procxx/kepka that referenced this pull request Apr 21, 2018
This option allows to turn off the old behaviour with replacing char
sequences like <<, >>, -- to chars represented by HTML escape characters
"&laquo;", "&raquo;", "&mdash;".

Based on upstream pull
telegramdesktop/tdesktop#4553 and commit
PeterMX/tdesktop@fe11883
from @PeterMX

Closes #132
@stek29
Copy link
Contributor

stek29 commented May 13, 2018

See 4b763a7

@stek29 stek29 closed this May 13, 2018
@github-actions
Copy link

github-actions bot commented Mar 4, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option for message formatting (-- to ‏‎−, >> to », << to «)
7 participants