Use PHPMD for code validation #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
fix MissingImport warning
…values to variables in if clauses and the like ..."
fix BooleanArgumentFlag The - [x] method getText has a boolean flag argument $without_cmd, which is a certain sign of a Single Responsibility Principle violation. - [x] The method printError has a boolean flag argument $return, which is a certain sign of a Single Responsibility Principle violation. - [x] The method printError has a boolean flag argument $return, which is a certain sign of a Single Responsibility Principle violation.
…future expanding and handle bypassing the current status.
Moustafa-Elgammal
force-pushed
the
feature/use-php-mess-detect
branch
from
35ab149
to
9c47d9e
Compare
|
any update @shahradelahi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
NumberOfChildrenandCouplingBetweenObjectswarning messages. issue Enhancement code design for NumberOfChildren and CouplingBetweenObjects some classes. #9