TEP-0142: Introduce StepAction referencing syntax in Steps #7284

chitrangpatel · 2023-10-25T19:42:24Z

This PR adds the referencing syntax for StepActions in Stpes. It also adds the necessary conversion between v1beta1 and v1 and the necessary validation. The actual resolution of the referenced StepAction will be implemented in a followup PR.

This is the third item on the implementation Issue #7259

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

[WIP] Introduces referencing syntax for StepAction in Steps

/kind feature

tekton-robot · 2023-10-25T19:51:23Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9

tekton-robot · 2023-10-25T19:52:19Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9

tekton-robot · 2023-10-25T20:08:42Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9

tekton-robot · 2023-10-25T20:11:44Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9

docs/stepactions.md

QuanZhang-William

Thanks Chitrang, left some small comments

docs/stepactions.md

pkg/apis/pipeline/v1/task_validation_test.go

pkg/apis/pipeline/v1beta1/container_types.go

chitrangpatel · 2023-10-25T22:36:19Z

Thanks Chitrang, left some small comments

Thanks Quan! PTAL, I implemented them.

tekton-robot · 2023-10-25T22:40:11Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9

tekton-robot · 2023-10-25T22:42:42Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9

tekton-robot · 2023-10-25T22:44:59Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9

chitrangpatel · 2023-10-26T02:37:09Z

/retest

tekton-robot · 2023-10-26T11:59:16Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9

tekton-robot · 2023-10-26T12:00:08Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9

tekton-robot · 2023-10-26T12:37:47Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9

tekton-robot · 2023-10-26T12:39:19Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9

jerop · 2023-10-26T14:46:27Z

@tektoncd/core-maintainers please take a look 🙏🏾

pkg/apis/pipeline/v1/task_validation_test.go

test/parse/yaml.go

This PR adds the referencing syntax for `StepActions` in `Stpes`. It also adds the necessary conversion between `v1beta1` and `v1` and the necessary validation.

tekton-robot · 2023-10-26T17:18:35Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9

tekton-robot · 2023-10-26T17:19:20Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/pipeline/v1/task_validation.go	97.3%	98.1%	0.9
pkg/apis/pipeline/v1beta1/task_validation.go	97.3%	98.2%	0.9

tekton-robot · 2023-10-26T17:26:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, QuanZhang-William, Yongxuanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Yongxuanzhang,jerop]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jerop · 2023-10-27T12:57:25Z

thank you for breaking down this work @chitrangpatel 🙏🏾

/lgtm

adding this note as suggested in tektoncd/community#1097 (comment):

sought more input here and on slack but haven't received any yet, we already have 3 approvals and this is specific change was discussed in a TEP plus it can be easily changed if needed (alpha), so merging to unblock progress for this series of pull requests targeting v0.54

tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 25, 2023

tekton-robot requested review from dibyom and pritidesai October 25, 2023 19:42

tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 25, 2023

This was referenced Oct 25, 2023

TEP-0142: Enable Step Reusability - Implementation #7259

Closed

TEP-0142: Referencing StepActions in Steps #7271

Merged

chitrangpatel force-pushed the introduce-step-ref branch from 10922cc to 94d2fd7 Compare October 25, 2023 20:02

jerop changed the title ~~Introduce StepAction referencing syntax in Steps~~ TEP-0142: Introduce StepAction referencing syntax in Steps Oct 25, 2023

jerop reviewed Oct 25, 2023

View reviewed changes

docs/stepactions.md Show resolved Hide resolved

QuanZhang-William reviewed Oct 25, 2023

View reviewed changes

docs/stepactions.md Outdated Show resolved Hide resolved

pkg/apis/pipeline/v1/task_validation_test.go Outdated Show resolved Hide resolved

pkg/apis/pipeline/v1beta1/container_types.go Outdated Show resolved Hide resolved

chitrangpatel force-pushed the introduce-step-ref branch 2 times, most recently from 7a11438 to d41efa8 Compare October 25, 2023 22:36

chitrangpatel requested a review from QuanZhang-William October 25, 2023 22:36

chitrangpatel force-pushed the introduce-step-ref branch from d41efa8 to bdf455d Compare October 26, 2023 11:52

chitrangpatel force-pushed the introduce-step-ref branch from bdf455d to 782a8ab Compare October 26, 2023 12:31

jerop approved these changes Oct 26, 2023

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023

QuanZhang-William approved these changes Oct 26, 2023

View reviewed changes

Yongxuanzhang reviewed Oct 26, 2023

View reviewed changes

pkg/apis/pipeline/v1/task_validation_test.go Outdated Show resolved Hide resolved

test/parse/yaml.go Outdated Show resolved Hide resolved

Introduce StepAction referencing syntax in Steps

f96950d

This PR adds the referencing syntax for `StepActions` in `Stpes`. It also adds the necessary conversion between `v1beta1` and `v1` and the necessary validation.

chitrangpatel force-pushed the introduce-step-ref branch from 782a8ab to f96950d Compare October 26, 2023 17:09

Yongxuanzhang approved these changes Oct 26, 2023

View reviewed changes

jerop added this to the Pipelines v0.54 milestone Oct 26, 2023

tekton-robot assigned jerop Oct 27, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023

tekton-robot merged commit 43ac007 into tektoncd:main Oct 27, 2023

TEP-0142: Introduce StepAction referencing syntax in Steps #7284

TEP-0142: Introduce StepAction referencing syntax in Steps #7284

Uh oh!

Conversation

chitrangpatel commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Submitter Checklist

Release Notes

Uh oh!

tekton-robot commented Oct 25, 2023

Uh oh!

tekton-robot commented Oct 25, 2023

Uh oh!

tekton-robot commented Oct 25, 2023

Uh oh!

tekton-robot commented Oct 25, 2023

Uh oh!

Uh oh!

QuanZhang-William left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chitrangpatel commented Oct 25, 2023

Uh oh!

tekton-robot commented Oct 25, 2023

Uh oh!

tekton-robot commented Oct 25, 2023

Uh oh!

tekton-robot commented Oct 25, 2023

Uh oh!

chitrangpatel commented Oct 26, 2023

Uh oh!

tekton-robot commented Oct 26, 2023

Uh oh!

tekton-robot commented Oct 26, 2023

Uh oh!

tekton-robot commented Oct 26, 2023

Uh oh!

tekton-robot commented Oct 26, 2023

Uh oh!

jerop commented Oct 26, 2023

Uh oh!

Uh oh!

Uh oh!

tekton-robot commented Oct 26, 2023

Uh oh!

tekton-robot commented Oct 26, 2023

Uh oh!

tekton-robot commented Oct 26, 2023

Uh oh!

jerop commented Oct 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chitrangpatel commented Oct 25, 2023 •

edited

Loading