Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.41.x] Make sure we pass the live config to the conversion webhook #6461

Merged
merged 1 commit into from
Mar 30, 2023
Merged

[release-v0.41.x] Make sure we pass the live config to the conversion webhook #6461

merged 1 commit into from
Mar 30, 2023

Commits on Mar 29, 2023

  1. Make sure we pass the live config to the conversion webhook 

    This makes sure we pass the "live" configuration to the conversion
webhook. Without this, that controller doesn't see any changes on the
`feature-flags` configmap, and thus only uses the default value.

This is a relatively big problem if some part of the conversion
depends on it (which was the case for `embedded-status` for example)
as it would cause loss of data.

Signed-off-by: Vincent Demeester <[email protected]>
    @vdemeester
    vdemeester authored and tekton-robot committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    1f90329 View commit details
    Browse the repository at this point in the history