Hygiene: enable `errorlint`. #6340

bendory · 2023-03-09T21:06:31Z

There are no expected functional changes in this PR.

Made non-functional code changes to adhere to Golang error standards.

Added // nolint pragmas in 4 files that violate existing Golang error conventions; @Yongxuanzhang is fixing those issues separately.

Context: #5899

See related style docs:

/kind cleanup

[N/A] Has Docs included if any changes are user facing
[N/A] Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including functionality, content, code)
Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[N/A] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[N/A] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

NONE

bendory · 2023-03-09T21:12:12Z

/unhold

tekton-robot · 2023-03-09T21:13:54Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-09T21:16:26Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
cmd/entrypoint/runner.go	84.4%	82.8%	-1.6
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-09T21:18:49Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

Yongxuanzhang · 2023-03-09T22:09:36Z

Thanks! I think I have a fix for those violations, it can pass the linter check. I can open a PR once this is merged.

bendory · 2023-03-09T23:10:08Z

Thanks! I think I have a fix for those violations, it can pass the linter check. I can open a PR once this is merged.

Great!

bendory · 2023-03-09T23:10:49Z

/retest-required

tekton-robot · 2023-03-09T23:23:34Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
cmd/entrypoint/runner.go	82.8%	84.4%	1.6
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-09T23:25:51Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
cmd/entrypoint/runner.go	82.8%	84.4%	1.6
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-10T13:28:20Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-10T13:29:36Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-14T12:13:36Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
cmd/entrypoint/runner.go	82.8%	84.4%	1.6
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-14T12:14:42Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
cmd/entrypoint/runner.go	82.8%	84.4%	1.6
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-14T21:04:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-14T21:05:09Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-16T18:06:32Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
cmd/entrypoint/runner.go	84.4%	82.8%	-1.6
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-16T18:08:05Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.3%	88.3%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-16T21:28:49Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	88.4%	88.4%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-16T21:33:05Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	88.4%	88.4%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

wlynch

/lgtm

tekton-robot · 2023-03-28T15:43:39Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.3%	-0.4
cmd/entrypoint/runner.go	85.2%	83.9%	-1.3
pkg/entrypoint/entrypointer.go	87.8%	87.2%	-0.7
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-28T15:44:47Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.3%	-0.4
cmd/entrypoint/runner.go	85.2%	83.9%	-1.3
pkg/entrypoint/entrypointer.go	87.8%	87.2%	-0.7
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-28T17:27:03Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
cmd/entrypoint/runner.go	85.2%	83.3%	-1.9
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-28T17:28:00Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

cmd/entrypoint/main.go

tekton-robot · 2023-03-28T20:32:15Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-28T20:33:18Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-28T20:42:02Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-28T20:43:41Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

bendory · 2023-03-29T02:00:21Z

/unhold

tekton-robot · 2023-03-29T02:06:24Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
cmd/entrypoint/runner.go	83.3%	85.2%	1.9
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-29T02:20:00Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
cmd/entrypoint/runner.go	83.3%	85.2%	1.9
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

cmd/entrypoint/subcommands/subcommands_test.go

tekton-robot · 2023-03-29T22:21:24Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-29T22:22:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

There are no expected functional changes in this PR. Made non-functional code changes to adhere to Golang error standards. Context: #5899 See related style docs: - https://pkg.go.dev/errors - https://go.dev/blog/errors-are-values /kind cleanup - [N/A] Has [Docs](https://github.com/tektoncd/community/blob/main/standards.md#docs) included if any changes are user facing - [N/A] Has [Tests](https://github.com/tektoncd/community/blob/main/standards.md#tests) included if any functionality added or changed - [x] Follows the [commit message standard](https://github.com/tektoncd/community/blob/main/standards.md#commits) - [x] Meets the [Tekton contributor standards](https://github.com/tektoncd/community/blob/main/standards.md) (including functionality, content, code) - [x] Has a kind label. You can add one by adding a comment on this PR that contains `/kind <type>`. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep - [N/A] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings) - [N/A] Release notes contains the string "action required" if the change requires additional action from users switching to the new release ```release-note NONE ```

tekton-robot · 2023-03-30T17:06:22Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

tekton-robot · 2023-03-30T17:07:28Z

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File	Old Coverage	New Coverage	Delta
cmd/entrypoint/main.go	12.7%	12.5%	-0.2
pkg/reconciler/pipelinerun/pipelinerun.go	88.7%	88.7%	0.0
pkg/remote/resolution/error.go	50.0%	33.3%	-16.7
pkg/resolution/common/errors.go	18.8%	17.6%	-1.1

wlynch

/lgtm

cmd/entrypoint/subcommands/subcommands_test.go

tekton-robot · 2023-03-30T20:01:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [wlynch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot requested review from afrittoli, imjasonh and wlynch March 9, 2023 21:06

bendory mentioned this pull request Mar 9, 2023

Cleanup: uplevel our technical hygiene by enabling additional Golang linters #5899

Closed

39 tasks

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 9, 2023

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2023

wlynch approved these changes Mar 22, 2023

View reviewed changes

Yongxuanzhang reviewed Mar 28, 2023

View reviewed changes

cmd/entrypoint/main.go Outdated Show resolved Hide resolved

tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 28, 2023

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2023

bendory requested review from wlynch and removed request for imjasonh and afrittoli March 29, 2023 02:55

wlynch reviewed Mar 29, 2023

View reviewed changes

cmd/entrypoint/subcommands/subcommands_test.go Show resolved Hide resolved

wlynch approved these changes Mar 30, 2023

View reviewed changes

cmd/entrypoint/subcommands/subcommands_test.go Show resolved Hide resolved

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2023

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2023

tekton-robot merged commit d3f8f3a into tektoncd:main Mar 30, 2023

bendory deleted the e2 branch March 30, 2023 21:57

Hygiene: enable errorlint. #6340

Hygiene: enable errorlint. #6340

Conversation

bendory commented Mar 9, 2023 • edited Loading

bendory commented Mar 9, 2023

tekton-robot commented Mar 9, 2023

tekton-robot commented Mar 9, 2023

tekton-robot commented Mar 9, 2023

Yongxuanzhang commented Mar 9, 2023

bendory commented Mar 9, 2023

bendory commented Mar 9, 2023

tekton-robot commented Mar 9, 2023

tekton-robot commented Mar 9, 2023

tekton-robot commented Mar 10, 2023

tekton-robot commented Mar 10, 2023

tekton-robot commented Mar 14, 2023

tekton-robot commented Mar 14, 2023

tekton-robot commented Mar 14, 2023

tekton-robot commented Mar 14, 2023

tekton-robot commented Mar 16, 2023

tekton-robot commented Mar 16, 2023

tekton-robot commented Mar 16, 2023

tekton-robot commented Mar 16, 2023

wlynch left a comment

Choose a reason for hiding this comment

tekton-robot commented Mar 28, 2023

tekton-robot commented Mar 28, 2023

tekton-robot commented Mar 28, 2023

tekton-robot commented Mar 28, 2023

tekton-robot commented Mar 28, 2023

tekton-robot commented Mar 28, 2023

tekton-robot commented Mar 28, 2023

tekton-robot commented Mar 28, 2023

bendory commented Mar 29, 2023

tekton-robot commented Mar 29, 2023

tekton-robot commented Mar 29, 2023

tekton-robot commented Mar 29, 2023

tekton-robot commented Mar 29, 2023

tekton-robot commented Mar 30, 2023

tekton-robot commented Mar 30, 2023

wlynch left a comment

Choose a reason for hiding this comment

tekton-robot commented Mar 30, 2023

Hygiene: enable `errorlint`. #6340

Hygiene: enable `errorlint`. #6340

bendory commented Mar 9, 2023 •

edited

Loading