TEP-0107: Deprecated implicit parameters #4906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tekton Pipelines resources are verbose mostly because of explicitly propagating Parameters. Implicit Parameters feature was added to reduce the verbosity. However, there are challenges caused by mutating specifications to support Implicit Parameters. This PR deprecates existing implementation of implicit parameters. A followup PR will address improvements to this and allow propagating paramaters that the task requires.
tekton-robot
added
the
release-note
tekton-robot
added
the
size/XXL
|
/assign @jerop |
|
/retest |
|
For reviewers, the feature replacing this feature is implemented in #4845 (both PRs are in the same milestone) as proposed in TEP-0107: Propagating Parameters. |
jerop
approved these changes
May 24, 2022
There was a problem hiding this comment.
thank you @chitrangpatel!
please add references to TEP-0107 and the implementation PR of the replacement feature to the commit message and this PR description so that the full context is available
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-go-coverage |
1 similar comment
|
/test pull-tekton-pipeline-go-coverage |
tekton-robot
added
the
kind/feature
|
The following is the coverage report on the affected files.
|
Done :) |
|
/lgtm |
jerop
changed the title
jerop
added a commit
to jerop/community
that referenced
this pull request
May 26, 2022
Marking TEP-0107 as implemented, thank you @chitrangpatel! Pull Requests: - tektoncd/pipeline#4906 - tektoncd/pipeline#4845
jerop
added a commit
to jerop/community
that referenced
this pull request
May 26, 2022
Marking TEP-0107 as implemented, thank you @chitrangpatel! Pull Requests: - tektoncd/pipeline#4906 - tektoncd/pipeline#4845
jerop
added a commit
to jerop/community
that referenced
this pull request
May 26, 2022
Marking TEP-0107 as implemented, thank you @chitrangpatel! Pull Requests: - tektoncd/pipeline#4906 - tektoncd/pipeline#4845
tekton-robot
pushed a commit
to tektoncd/community
that referenced
this pull request
May 26, 2022
Marking TEP-0107 as implemented, thank you @chitrangpatel! Pull Requests: - tektoncd/pipeline#4906 - tektoncd/pipeline#4845
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
Jun 16, 2022
Propagated `Parameters` was designed and implemented to replace Implicit `Parameters` to remove the mutation of specifications. In this change, we update the alpha features table to remove the Implicit `Parameters` and the broken link to its documentation, and replace them with Propagated `Parameters`. TEPs: - https://github.com/tektoncd/community/blob/main/teps/0107-propagating-parameters.md - https://github.com/tektoncd/community/blob/main/teps/0023-implicit-mapping.md PRs: - tektoncd#4906 - tektoncd#4845
3 tasks
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
Jun 17, 2022
Propagated `Parameters` was designed and implemented to replace Implicit `Parameters` to remove the mutation of specifications. In this change, we update the alpha features table to remove the Implicit `Parameters` and the broken link to its documentation, and replace them with Propagated `Parameters`. TEPs: - https://github.com/tektoncd/community/blob/main/teps/0107-propagating-parameters.md - https://github.com/tektoncd/community/blob/main/teps/0023-implicit-mapping.md PRs: - tektoncd#4906 - tektoncd#4845
jerop
added a commit
to jerop/pipeline
that referenced
this pull request
Jun 17, 2022
Propagated `Parameters` was designed and implemented to replace Implicit `Parameters` to remove the mutation of specifications. In this change, we update the alpha features table to remove the Implicit `Parameters` and the broken link to its documentation, and replace them with Propagated `Parameters`. TEPs: - https://github.com/tektoncd/community/blob/main/teps/0107-propagating-parameters.md - https://github.com/tektoncd/community/blob/main/teps/0023-implicit-mapping.md PRs: - tektoncd#4906 - tektoncd#4845
tekton-robot
pushed a commit
that referenced
this pull request
Jun 17, 2022
Propagated `Parameters` was designed and implemented to replace Implicit `Parameters` to remove the mutation of specifications. In this change, we update the alpha features table to remove the Implicit `Parameters` and the broken link to its documentation, and replace them with Propagated `Parameters`. TEPs: - https://github.com/tektoncd/community/blob/main/teps/0107-propagating-parameters.md - https://github.com/tektoncd/community/blob/main/teps/0023-implicit-mapping.md PRs: - #4906 - #4845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tekton Pipelines resources are verbose mostly because of explicitly propagating Parameters. Implicit Parameters feature was added to reduce the verbosity. However, there are challenges caused by mutating specifications to support Implicit Parameters. This PR deprecates existing implementation of implicit parameters. A followup PR will address improvements to this and allow propagating parameters that the task requires. This PR addresses part of TEP-0107 that includes removing existing implicit parameters.
/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
(if there are no user facing changes, use release note "NONE")
Release Notes