Stop using GO111MODULE=off in builds #4868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GO111MODULE=off was set back in 2019 tektoncd@1a1412e probably before we supported go modules for pipeline. GO111MODULE is not needed anymore, and it breaks SBOM generation. Rather than setting it GO111MODULE to "on", remove it, since its default value is "on" since go1.13 and we're now using go 1.18. Signed-off-by: Andrea Frittoli <[email protected]>
tekton-robot
added
release-note
tekton-robot
added
the
size/XS
|
/cc @vdemeester @imjasonh |
|
@tektoncd/core-maintainers can I have a second reviews on this, so we may start generating SBOM for nightly releases |
vdemeester
approved these changes
May 13, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
GO111MODULE=off was set back in 2019 in 1a1412e
probably before we supported go modules for pipeline.
GO111MODULE is not needed anymore, and it breaks SBOM generation.
Rather than setting it GO111MODULE to "on", remove it, since its
default value is "on" since go1.13 and we're now using go 1.18.
Signed-off-by: Andrea Frittoli [email protected]
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
(if there are no user facing changes, use release note "NONE")
Release Notes