Instrument the kaniko test for logstream.

[mattmoor]

We see this flaking a fair amount downstream, and this will make it easier to cross correlate our logs to see what's happening in the reconciler as things go awry.

This also fixes a place where we were improperly using a constant in pipelinerun_test.go.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Docs included if any changes are user facing
• Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Release notes block below has been filled in
  (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

[mattmoor]

One subtlety worth calling out: We always run logstream, but we need to name test resources using the helpers.ObjectNameForTest so that it can infer from the resource names, which tagged log lines from the controller to inline into each test's log context. That's why none of the changed lines mentioned logstream, but that's the net effect of the change 🤣

[mattmoor]

cc @afrittoli @vdemeester

[abayer]

/lgtm

Is there a good reason not to just update all the e2e tests to use helpers.ObjectNameForTest? Assuming there isn’t, I’ll get a PR up to do that across the board.

[mattmoor]

@abayer That's what we do in Knative, I've just been chipping away as we hit flakes where I wish I had it. Doing it everywhere would be awesome 🤩

[abayer]

@mattmoor Consider it done!

EDIT: Ok, not done instantly, 'cos there's a lot of spaghetti to unravel, but I'll work on it. =)

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment