Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Go libraries compatibility policy #4750

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Add Go libraries compatibility policy #4750

merged 1 commit into from
Apr 13, 2022

Conversation

lbernick
Copy link
Member

Changes

This change proposes that breaking changes may be introduced to the Go client libraries,
as long as existing yaml/json CRD definitions remain unaffected.

Breaking changes to the Go client libraries do not affect the Dashboard team, as the Dashboard
team no longer uses these libraries. The CLI team has decided that the impact of such changes
on them is acceptable.

Closes #2748.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • n/a Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

@lbernick
Add Go libraries compatibility policy
aaeae8d 
This change proposes that breaking changes may be introduced to the Go client libraries,
as long as existing yaml/json CRD definitions remain unaffected.

Breaking changes to the Go client libraries do not affect the Dashboard team, as the Dashboard
team no longer uses these libraries. The CLI team has decided that the impact of such changes
on them is acceptable.
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Apr 12, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 12, 2022
@abayer
Copy link
Contributor

abayer commented Apr 12, 2022

/retest

@abayer
Copy link
Contributor

abayer commented Apr 12, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2022
@abayer
Copy link
Contributor

abayer commented Apr 12, 2022

/retest

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2022
@vdemeester
Copy link
Member

/retest

@lbernick
Copy link
Member Author

/assign @pritidesai

@abayer
Copy link
Contributor

abayer commented Apr 13, 2022

/retest

@abayer abayer mentioned this pull request Apr 13, 2022
Merged
5 tasks
@abayer
Copy link
Contributor

abayer commented Apr 13, 2022

/retest

@abayer
Copy link
Contributor

abayer commented Apr 13, 2022

/retest

This was one of the "normal" flakes in pipeline-alpha-integration-tests, not the git-init problem.

@abayer
Copy link
Contributor

abayer commented Apr 13, 2022

/override pull-tekton-pipeline-alpha-integration-tests

So https://tekton-releases.appspot.com/build/tekton-prow/pr-logs/pull/tektoncd_pipeline/4750/pull-tekton-pipeline-alpha-integration-tests/1514290483927453696/ passed but is refusing to admit it's done. I'm gonna be a bad boy and try to override it. =)

@abayer
Copy link
Contributor

abayer commented Apr 13, 2022 •
edited
Loading

Eh, /override doesn't work, at least not for me. Ah well, it was a nice thought.

@abayer
Copy link
Contributor

abayer commented Apr 13, 2022

/test pull-tekton-pipeline-alpha-integration-tests

@abayer
Copy link
Contributor

abayer commented Apr 13, 2022

/retest

1 similar comment
@abayer
Copy link
Contributor

abayer commented Apr 13, 2022

/retest

@abayer
Copy link
Contributor

abayer commented Apr 13, 2022

The dang alpha integration tests finally passed! ...so of course, now they've all gotta be rebuilt since main has changed. Sigh. =)

@abayer
Copy link
Contributor

abayer commented Apr 13, 2022

/retest

shakes fist at flakes

@tekton-robot tekton-robot merged commit 688e696 into tektoncd:main Apr 13, 2022
@lbernick lbernick deleted the golib branch April 18, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@abayer abayer

@pritidesai pritidesai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define compatibility policy for Go libs
5 participants
@lbernick @abayer @tekton-robot @vdemeester @pritidesai