Disable implicit param behavior for Pipeline objects. #4511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
tekton-robot
added
the
size/XL
|
The following is the coverage report on the affected files.
|
We recently received feedback that the implicit param behavior
implementation was not quite implemented as expected in the TEP -
primarily, that the implicit behavior modifying Pipelines on admission
was unexpected. As a short term measure, this change disables the
implicit behavior for Pipelines, but keeps the PipelineRun and TaskRun
behavior in place.
This is implemented by introducing a new context variable, similar to
the existing Alpha context behavior, that is only enabled on
PipelineRun/TaskRun reconcile. This allows for minimially invasive
changes while giving us the flexibility to revert this behavior or
enable in other contexts such as during reconcile.
On top of this:
- Moves implicit param tests to their own file, adds test for Pipeline
to cover the behavior in question.
- Fixes bug with param context key using var struct{} instead of type
struct{} -> using var associates the value to any key of struct{},
whereas type struct{} creates a new type that can be used by only that
key. There's no indication that this was causing problems before.
wlynch
force-pushed
the
implicit-disable
branch
from
e2af920
to
8f09136
Compare
|
The following is the coverage report on the affected files.
|
ghost
added
the
needs-cherry-pick
|
/test pull-tekton-pipeline-alpha-integration-tests |
|
/lgtm Thanks @wlynch ! |
vdemeester
approved these changes
Jan 26, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
ghost
removed
the
needs-cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We received feedback that the implicit param implementation has behavior that
some users found unexpected - primarily, that the implicit behavior modifying
Pipelines on admission. This change disables the implicit behavior for Pipelines,
but keeps the PipelineRun and TaskRun behavior in place.
This is implemented by introducing a new context variable, similar to
the existing Alpha context behavior, that is only enabled on
PipelineRun/TaskRun reconcile. This allows for minimally invasive
changes while giving us the flexibility to revert this behavior or
enable in other contexts such as during reconcile.
On top of this:
to cover the behavior in question.
struct{} -> using var associates the value to any key of struct{},
whereas type struct{} creates a new type that can be used by only that
key. There's no indication that this was causing problems before.
/kind misc
Fixes #4388
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes