Implicit params: only propagate params to embedded TaskSpecs in Pipelines. #4484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were applying the params to all PipelineTasks, including refs. This is incorrect behavior since the parameters should only be propagated to things within the same document.
tekton-robot
added
release-note
tekton-robot
added
the
size/L
|
/hold (there's some additional discussion going on around this feature, so blocking submission for the time being) |
tekton-robot
added
the
do-not-merge/hold
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-pipeline-alpha-integration-tests |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
ghost
added
the
needs-cherry-pick
|
thank you @wlynch |
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
ghost
removed
the
needs-cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Previously we were appling the params to all PipelineTasks, including
refs. This is incorrect behavior since the parameters should only be
propagated to things within the same document.
Fixes #4483
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes