Test multiple scripts in one task executing with different UIDs #3914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit we weren't testing whether scripts were executable when UIDs differed from Step to Step in a single Task. This commit updates the step-script examples to vary the UID of each Step. A failure of one of these would indicate that a bug has been introduced in the permissions of the shell scripts that Tekton generates and places in the /tekton/scripts directory.
tekton-robot
added
the
release-note
tekton-robot
added
the
size/S
ghost
added
kind/misc
ghost
mentioned this pull request
5 tasks
|
/test pull-tekton-pipeline-integration-tests |
1 similar comment
|
/test pull-tekton-pipeline-integration-tests |
tekton-robot
added
the
size/S
vdemeester
approved these changes
May 5, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
thanks @sbwsg /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prior to this commit we weren't testing whether scripts were executable
when UIDs differed from Step to Step in a single Task.
This commit updates the step-script examples to vary the UID of each
Step. A failure of one of these would indicate a regression has
been introduced in the permissions of the shell scripts that Tekton
generates and places in the /tekton/scripts directory.
I added this test originally in #3888
to determine whether changing the script implementation
was introducing incorrect behaviour.
/kind testing
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes