Remove random suffixes on creds-init volumes #3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the random suffixes that used to appear on creds-init volumes. These didn't serve any purpose that couldn't be equally well-served with an incrementing integer. The benefit of doing it this way is that our unit tests become less brittle - those random suffixes were a source of considerable churn whenever other volumes were added or removed to test data because the random pool of suffixes was shared with those other volumes.
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/L
ghost
requested a review
from 
ghost
mentioned this pull request
5 tasks
afrittoli
reviewed
Apr 30, 2021
| cfg := config.FromContextOrDefaults(ctx) | ||
| if cfg != nil && cfg.FeatureFlags != nil && cfg.FeatureFlags.DisableCredsInit { | ||
| return nil, nil | ||
| } | ||
| name := names.SimpleNameGenerator.RestrictLengthWithRandomSuffix(credsInitHomeMountPrefix) | ||
| name := fmt.Sprintf("%s-%d", credsInitHomeMountPrefix, idx) |
There was a problem hiding this comment.
Given that credsInitHomeMountPrefix is a fixed, non configurable string, this looks good.
afrittoli
reviewed
Apr 30, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removed the random suffixes that used to appear on creds-init volumes. These
didn't serve any purpose that couldn't be equally well-served with an
incrementing integer.
The benefit of doing it this way is that our unit tests become less brittle -
those random suffixes were a source of considerable churn whenever other
volumes were added or removed to test data because the random pool of suffixes
was shared with those other volumes.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes