Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jerop as an owner 🎉 #3620

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Conversation

bobcatfish
Copy link
Collaborator

Changes

@jerop has been reviewed 32 PRs in pipelines
(https://github.com/tektoncd/pipeline/pulls?q=is%3Apr+reviewed-by%3Ajerop+-author%3Ajerop)
and has authored 27 PRs against this repo (https://github.com/tektoncd/pipeline/pulls/jerop)
including when expressions #3135,
in addition to making significant improvements to our processes
(e.g. defining design principles tektoncd/community#171
and recently proposing topical areas of ownership)

Thanks for all your hard work @jerop!!

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • [n/a] Includes tests (if functionality changed/added)
  • [n/a] Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

@jerop has been reviewed 32 PRs in pipelines
(https://github.com/tektoncd/pipeline/pulls?q=is%3Apr+reviewed-by%3Ajerop+-author%3Ajerop)
and has authored 27 PRs against this repo (https://github.com/tektoncd/pipeline/pulls/jerop)
including when expressions tektoncd#3135,
in addition to making significant improvements to our processes
(e.g. defining design principles tektoncd/community#171
and recently proposing topical areas of ownership)

Thanks for all your hard work @jerop!!
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Dec 9, 2020
@bobcatfish
Copy link
Collaborator Author

@tektoncd/core-maintainers

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2020
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
@bobcatfish
Copy link
Collaborator Author

whoa you are FAST @sbwsg :D 🏎️

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow
🎉

@tekton-robot
Copy link
Collaborator

@vdemeester: cat image

In response to this:

/meow
🎉

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pritidesai
Copy link
Member

🎉 🎉 🎉
/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai, sbwsg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pritidesai,sbwsg,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bobcatfish
Copy link
Collaborator Author

While we wait for more OWNERS @afrittoli @dibyom @dlorenc @imjasonh (who is on leave right now, i think we can safely consider him 👍 !)

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2020
@imjasonh
Copy link
Member

imjasonh commented Dec 9, 2020

/lgtm 👍

@bobcatfish
Copy link
Collaborator Author

oh hai @imjasonh XD

@dlorenc
Copy link
Contributor

dlorenc commented Dec 9, 2020

+1!

@afrittoli
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2020
@dibyom
Copy link
Member

dibyom commented Dec 9, 2020

/lgtm

@vdemeester
Copy link
Member

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2020
@tekton-robot tekton-robot merged commit ce1c9ca into tektoncd:master Dec 9, 2020
jerop added a commit to jerop/community that referenced this pull request Dec 15, 2020
Jerop was added as Pipelines Owner in tektoncd/pipeline#3620
tekton-robot pushed a commit to tektoncd/community that referenced this pull request Dec 15, 2020
Jerop was added as Pipelines Owner in tektoncd/pipeline#3620
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants