Use PATCH to update ready annotation #3494
Conversation
tekton-robot
added
release-note
|
The following is the coverage report on the affected files.
|
|
/retest |
|
Alright, let me add a |
|
/retest |
1 similar comment
|
/retest |
|
|
||
| func init() { | ||
| // https://stackoverflow.com/questions/55573724/create-a-patch-to-add-a-kubernetes-annotation | ||
| readyAnnotationPath := "/metadata/annotations/" + strings.Replace(readyAnnotation, "/", "~1", 1) |
There was a problem hiding this comment.
replacing forward slash in "tekton.dev/ready" with ~1: "tekton.dev~1ready" 😱 yup saw the linked RFC
|
thank you @imjasonh |
This should be faster and more reliable than the get-modify-write we use today.
|
The following is the coverage report on the affected files.
|
|
/lgtm |
|
@tektoncd/core-maintainers please if you have bandwidth to review this, we need this for 0.18 🙏 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/retest |
2 similar comments
|
/retest |
|
/retest |
This should be faster and more reliable than the get-modify-write we use
today.
Closes #3310
/kind cleanup
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes