Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readiness and liveness probes in controller #3489

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Add readiness and liveness probes in controller #3489

merged 1 commit into from
Nov 4, 2020

Conversation

ywluogg
Copy link
Contributor

@ywluogg ywluogg commented Nov 3, 2020

Add readiness and liveness probes in controller.
Closes #3111 and #1586.

The reason for adding the two probes are discussed in PR #3349.
Optional considered methods: using https-metrics ports. Current method is chosen based on discussions in PR #3349.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Add readiness and liveness probes in controller.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2020
@afrittoli afrittoli added this to the Pipelines v0.18 milestone Nov 4, 2020
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!
/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2020
@ghost
Copy link

ghost commented Nov 4, 2020

/lgtm

@tekton-robot tekton-robot assigned ghost Nov 4, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2020
@ywluogg
Copy link
Contributor Author

ywluogg commented Nov 4, 2020

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a tekton pipeline user, I want to use liveness/readiness probes to check controller pod health
3 participants