Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the parameter is not used in func #3470

Merged
merged 1 commit into from
Nov 2, 2020
Merged

remove the parameter is not used in func #3470

merged 1 commit into from
Nov 2, 2020

Conversation

soulseen
Copy link
Contributor

@soulseen soulseen commented Oct 29, 2020 •
edited
Loading

Signed-off-by: Xiaoyang Zhu [email protected]

Changes

remove the parameter is not used in the taskrun reconcile function.

Release Notes

NONE

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Oct 29, 2020
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 29, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 29, 2020
@tekton-robot
Copy link
Collaborator

Hi @soulseen. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost
Copy link

ghost commented Oct 29, 2020

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 29, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Oct 29, 2020
@soulseen
Copy link
Contributor Author

soulseen commented Nov 2, 2020

hi, @sbwsg please look at this pr, thanks.

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2020
jerop
jerop reviewed Nov 2, 2020
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/release-note-none

@jerop
Copy link
Member

jerop commented Nov 2, 2020

@soulseen tried to add the release note label using /release-note-none prow command but didn't seem to work, but you should be able to add the required release note label by following the instructions in the pull request template

@soulseen
Copy link
Contributor Author

soulseen commented Nov 2, 2020

/release-note-none

@soulseen
Copy link
Contributor Author

soulseen commented Nov 2, 2020 •
edited
Loading

@jerop looks like get some wrong with prow, and I add the release note "NONE" in the PR description.

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 2, 2020
@soulseen soulseen requested a review from jerop November 2, 2020 15:39
@jerop
Copy link
Member

jerop commented Nov 2, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2020
@jerop
Copy link
Member

jerop commented Nov 2, 2020

/test pull-tekton-pipeline-integration-tests

@tekton-robot tekton-robot merged commit dc07540 into tektoncd:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@dlorenc dlorenc Awaiting requested review from dlorenc

@jerop jerop Awaiting requested review from jerop

Assignees

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soulseen @tekton-robot @jerop