Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template to try and avoid /kind being automatically set #3414

Merged
merged 1 commit into from Oct 20, 2020
Merged

Update PR template to try and avoid /kind being automatically set #3414

merged 1 commit into from Oct 20, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 20, 2020

We recently updated the PR template to include some useful examples of
the /kind command. Unfortunately Prow will see those even though they're
inside a comment and apply them to the PR.

This commit removes the valid kind examples and replaces them with some
more text hopefully explaining enough how to use them.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes docs (if user facing)
  • Commit messages follow commit message best practices
  • Release notes block has been filled in or deleted (only if no user facing changes)

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

NONE

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 20, 2020
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 20, 2020
@ghost
Copy link
Author

ghost commented Oct 20, 2020

/kind documentation

We recently updated the PR template to include some useful examples of
the /kind command. Unfortunately Prow will see those even though they're
inside a comment and apply them to the PR.

This commit removes the valid kind examples and replaces them with some
more text hopefully explaining enough how to use them.
@ghost ghost removed kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 20, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2020
@jerop
Copy link
Member

jerop commented Oct 20, 2020

/lgtm

@ghost
Copy link
Author

ghost commented Oct 20, 2020

/test tekton-pipeline-unit-tests

@ghost
Copy link
Author

ghost commented Oct 20, 2020

/test pull-tekton-pipeline-build-tests

@ghost
Copy link
Author

ghost commented Oct 20, 2020

/test tekton-pipeline-unit-tests

/test pull-tekton-pipeline-build-tests

@ghost
Copy link
Author

ghost commented Oct 20, 2020

# FAILED!
# Cloning tektoncd/pipeline at master(8871a5894ed33d3dd1ca2a6882418d85b5ecbb4a)
# Checking out pulls:
#	3414(d9065a8c2ec0d3ab7ccc7a0ad1b3c592fe105b2b)
$ mkdir -p /home/prow/go/src/github.com/tektoncd/pipeline
$ git init
Initialized empty Git repository in /home/prow/go/src/github.com/tektoncd/pipeline/.git/
$ git config user.name ci-robot
$ git config user.email [email protected]
$ git fetch https://github.com/tektoncd/pipeline.git --tags --prune
fatal: unable to access 'https://github.com/tektoncd/pipeline.git/': Could not resolve host: github.com
# Error: exit status 128

@ghost
Copy link
Author

ghost commented Oct 20, 2020

/test tekton-pipeline-unit-tests

@tekton-robot tekton-robot merged commit c04c2b4 into tektoncd:master Oct 20, 2020
@ghost ghost deleted the pr-template-kind-label-tweak branch October 20, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants