-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PR template to try and avoid /kind being automatically set #3414
Conversation
/kind documentation |
We recently updated the PR template to include some useful examples of the /kind command. Unfortunately Prow will see those even though they're inside a comment and apply them to the PR. This commit removes the valid kind examples and replaces them with some more text hopefully explaining enough how to use them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/test tekton-pipeline-unit-tests |
/test pull-tekton-pipeline-build-tests |
/test tekton-pipeline-unit-tests /test pull-tekton-pipeline-build-tests |
|
/test tekton-pipeline-unit-tests |
We recently updated the PR template to include some useful examples of
the /kind command. Unfortunately Prow will see those even though they're
inside a comment and apply them to the PR.
This commit removes the valid kind examples and replaces them with some
more text hopefully explaining enough how to use them.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes