Make ConditionCheck container names DNS-safe #3394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
release-note
tekton-robot
added
the
size/S
|
/assign @imjasonh @afrittoli @vdemeester |
imjasonh
reviewed
Oct 15, 2020
|
TIL, I can try to find it and use that instead. |
My recent change uncovered a latent bug where especially long test names result in especially long container names, which fails certain validations. Unfortunately it slipped in because the test was expected to fail. This leverages the names.SimpleNameGenerator.RestrictLength helper to solve this problem. Fixes: tektoncd#3393
mattmoor
changed the title
|
Alright, I think this is now done. LMK if this is/isn't what you meant. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
My recent change uncovered a latent bug where especially long test names result in especially long container names, which fails certain validations. Unfortunately it slipped in because the test was expected to fail.
This leverages an upstream helper we created to solve ~exactly this problem. You get DNS-safe short names based on an input name and a suffix, which are deterministic, and are friendly for suitably short inputs.
Fixes: #3393
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes
/kind bug