When Expressions Status #3333
Merged
When Expressions Status #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
do-not-merge/work-in-progress
tekton-robot
added
the
size/M
jerop
force-pushed
the
when-expressions-in-status
branch
from
e820102
to
04eb12c
Compare
tekton-robot
removed
the
needs-rebase
jerop
force-pushed
the
when-expressions-in-status
branch
from
04eb12c
to
80ae859
Compare
|
The following is the coverage report on the affected files.
|
When a Task is skipped because its When Expressions evaluated to false, its resolved When Expressions are listed alongside the PipelineTaskName in the SkippedTasks section of the PipelineRunStatus. When a Task is executed because its When Expressions evaluated to true, its resolved When Expressions are listed in the TaskRuns section of the PipelineRunStatus. Further details in https://github.com/tektoncd/community/blob/master/teps/0007-conditions-beta.md#status-1 Closes tektoncd#3139
|
The following is the coverage report on the affected files.
|
jerop
force-pushed
the
when-expressions-in-status
branch
from
80ae859
to
a068915
Compare
|
/kind feature |
tekton-robot
added
the
kind/feature
|
The following is the coverage report on the affected files.
|
tekton-robot
added
kind/feature
ghost
approved these changes
Oct 6, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-build-tests |
|
/test check-pr-has-kind-label |
|
/test pull-tekton-pipeline-build-tests |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When a Task is skipped because its When Expressions evaluated to false,
its resolved When Expressions are listed alongside the PipelineTaskName
in the SkippedTasks section of the PipelineRunStatus
When a Task is executed because its When Expressions evaluate to true,
its resolved When Expressions are listed in the TaskRuns section of the
PipelineRunStatus
Further details in the TEP
Closes #3139
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes