-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update example paths and yaml names in README #2744
Conversation
Hi @tedhtchang. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR cannot be merged: expecting exactly one kind/ label Available
|
2 similar comments
This PR cannot be merged: expecting exactly one kind/ label Available
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
Thanks @tedhtchang looks like you'll need to accept the EasyCLA before this will merge. /ok-to-test |
This PR cannot be merged: expecting exactly one kind/ label Available
|
Could you also remove the Release Notes and any other irrelevant information from the PR description? /kind documentation |
This PR cannot be merged: expecting exactly one kind/ label Available
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you, please squash the 2 commits down into 1.
Two of the the example yaml files no longer exist under the current path. Updated the yaml file names and path to these files to reflect the current structure. Per @sbwsg, use v1beta1 as the preferred path.
6bafe39
to
54666b8
Compare
@sbwsg I squashed. Thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Two of the the example yaml files no longer exist under the current path.
Updated the yaml file names and path to these files to reflect the current
structure.