Refactoring in sidecar test #2733
Conversation
It will now run as parallel and also will create a nmespace Use simple busybox image
tekton-robot
added
the
size/S
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
1 similar comment
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
|
/kind flake |
tekton-robot
added
the
kind/flake
| @@ -62,13 +67,13 @@ func TestSidecarTaskSupport(t *testing.T) { | |||
| task := tb.Task(sidecarTaskName, | |||
| tb.TaskSpec( | |||
| tb.Step( | |||
| "busybox:1.31.0-musl", | |||
There was a problem hiding this comment.
Thanks for this! Couple questions:
- Could you add something to the commit message explaining why this is preferred?
- What is this doing now? Pulling in ":latest"? If so, should we simply pin to today's "latest" version / digest so that it remains a constant going forward for our tests? If not, why?
There was a problem hiding this comment.
-
There is no such difference to prefer, the job required can be done by
busyboximage and we are using that in many e2e tests, whilebusybox image based on muslis used only in this test so it will avoid this image pulling. I just used a simple busybox image as for the e2e test, it is just doingechoand doesn't have any scenario to use the alpine based image. -
If you see all the e2e tests, in every test except one it is just
busyboxso I used it here also the same way.
There was a problem hiding this comment.
Fantastic, thanks for explaining. I didn't know that this was what we use everywhere else so it's good to know.
There was a problem hiding this comment.
It would be great to get this in the commit message too. Even when something is extremely obvious it really helps to have the context of the change described. Otherwise I need to just "somehow" know.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-integration-tests |
It will now run as parallel and also will create a
namespace
Use simple busybox image
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes