-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
events: rename EmitEvent and EmitErrorEvent 🌲 #2730
Conversation
This renames two methods: events.EmitEvent -> events.Emit events.EmitErrorEvent -> events.EmitError It keeps the old name and mark them as Deprecated (so that external user of those function are not broken). Signed-off-by: Vincent Demeester <[email protected]>
/kind cleanup |
This PR cannot be merged: expecting exactly one kind/ label Available
|
1 similar comment
This PR cannot be merged: expecting exactly one kind/ label Available
|
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-tekton-pipeline-integration-tests |
Changes
This renames two methods:
events.EmitEvent -> events.Emit
events.EmitErrorEvent -> events.EmitError
It keeps the old name and mark them as Deprecated (so that external
user of those function are not broken).
Signed-off-by: Vincent Demeester [email protected]
This is a small follow-up to #2655
/cc @afrittoli @bobcatfish @dibyom
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmd
dir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes