Fix helm chart for deprecated extensions/v1beta1 #2652
Conversation
|
/kind bug |
tekton-robot
added
size/XS
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
1 similar comment
|
This PR cannot be merged: expecting exactly one kind/ label Available
|
|
@afrittoli we may need to disable the tests temporarly ? |
The helm test was temporarily disabled until tektoncd#2652 as merged. Re-nabled it now. Depends-on tektoncd#2652
tekton-robot
added
the
approved
|
/test pull-tekton-pipeline-integration-tests |
|
/lgtm |
test/helm_task_test.go
Outdated
| t.Errorf("Error waiting for PipelineRun %s to finish: %s", helmDeployPipelineRunName, err) | ||
| t.Fatalf("PipelineRun execution failed; helm may or may not have been installed :(") | ||
| t.Logf("Error waiting for PipelineRun %s to finish: %s", helmDeployPipelineRunName, err) | ||
| t.Logf("PipelineRun execution failed; helm may or may not have been installed :(") |
There was a problem hiding this comment.
Since the chart is pulled from master, temporary let the test pass
until this is merged, then we can enforce back the check.
eek!
i think it would make sense to include a comment maybe at this point in the test to explain why this isn't being enforced anymore? I dont wanna block the fix tho and im guessing we'll update this immediately after the merge tho!
There was a problem hiding this comment.
Yeah, but it looks like this is not enough anyways because the CI tests timed-out, so I guess they're waiting for too long. I'll make another fix.
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobcatfish, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As of k8s 1.16 extensions/v1beta1 is deprecated, so the deployment in the test helm chart should be fixed accordingly. Since the chart is pulled from master, temporary let the test pass until this is merged, then we can enforce back the check.
|
/test tekton-pipeline-unit-tests |
|
/lgtm |
|
/lgtm |
The helm chart test was disabled in tektoncd#2652 to solve an issue with the helm chart. Re-enable the test now.
The helm chart test was disabled in #2652 to solve an issue with the helm chart. Re-enable the test now.
Changes
As of k8s 1.16 extensions/v1beta1 is deprecated, so the deployment
in the test helm chart should be fixed accordingly.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.