Change TimeoutHandler to respect namespace scoping

[dghubble]

Changes

• Pass --namespace value to taskrun and pipelinerun NewController
  to facilitate namespace-scoped behaviors
• Change TimeoutHandler CheckTimeouts to timeout taskrun/pipelinerun's
  in the scoped namespace or all namespaces (default if unset)

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing) (NA)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Avoid performing a cluster-level namespace list when --namespace is set

Fix #2603

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Dalton Hubble (b850226)

[tekton-robot]

Hi @dghubble. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vdemeester]

/meow
/cc @sbwsg @bobcatfish

[tekton-robot]

@vdemeester:

In response to this:

/meow
/cc @sbwsg @bobcatfish

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bobcatfish]

/ok-to-test

[vdemeester]

/ok-to-test

ah lol, I forgot to do that 😓

[dghubble]

I think the v1alpha build problem was from CI merging this with #2577, I've rebased. I notice this project requires a Go v1.14 feature for tests (t.Cleanup). Therefore I used a Go v1.14.2 container to run make test-unit and is passes.

Does this project include a Dockerfile or image build? I'd like to also confirm the fix by actually running it.

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/reconciler/timeout_handler.go	75.2%	76.4%	1.2

[dghubble]

I think this is ok to review again

[vdemeester]

/kind bug

[vdemeester]

/lgtm