Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link from API Policy to Deprecations Table #2544

Merged
merged 1 commit into from May 5, 2020
Merged

Add a link from API Policy to Deprecations Table #2544

merged 1 commit into from May 5, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 5, 2020

Changes

In a prior commit we added a table of deprecations which lists
the earliest date at which deprecated features can be removed
in line with our API policy.

This commit adds a link to the deprecations table from the API
policy document.

Suggested in previous PR comment.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

@ghost ghost added the kind/documentation Categorizes issue or PR as related to documentation. label May 5, 2020
@ghost ghost requested a review from bobcatfish May 5, 2020 12:37
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 5, 2020
@ghost
Copy link
Author

ghost commented May 5, 2020

/test pull-tekton-pipeline-build-tests

3 similar comments
@ghost
Copy link
Author

ghost commented May 5, 2020

/test pull-tekton-pipeline-build-tests

@ghost
Copy link
Author

ghost commented May 5, 2020

/test pull-tekton-pipeline-build-tests

@ghost
Copy link
Author

ghost commented May 5, 2020

/test pull-tekton-pipeline-build-tests

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2020
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2020
@vdemeester
Copy link
Member

/test pull-tekton-pipeline-build-tests

@ghost ghost mentioned this pull request May 5, 2020
3 tasks
In a prior commit we added a table of deprecations which lists
the earliest date at which deprecated features can be removed
in line with our API policy.

This commit adds a link to the deprecations table from the API
policy document.
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label May 5, 2020
@bobcatfish
Copy link
Collaborator

Thanks @sbwsg !

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2020
@ghost
Copy link
Author

ghost commented May 5, 2020

===============================
==== RUNNING GOLANGCI-LINT ====
===============================
level=error msg="Running error: context loading failed: no go files to analyze"
level=error msg="Timeout exceeded: try increasing it by passing --timeout option"
============================
==== BUILD TESTS FAILED ====
============================

@ghost
Copy link
Author

ghost commented May 5, 2020

/test pull-tekton-pipeline-build-tests

@tekton-robot tekton-robot merged commit ea1a09a into tektoncd:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants