Add recommended k8s labels #2501

eddycharly · 2020-04-28T09:08:38Z

This PR adds recommended k8s labels on resources.
Implementation for proposal #2497

Config: added labels and updated selectors for all resources in /config
Doc: added /docs/developers/resources-labelling.md

NOTE: this will introduce a breaking change when trying to update deployments as label selectors have changed.

eddycharly · 2020-04-28T09:08:58Z

/cc @vdemeester

eddycharly · 2020-04-28T09:13:51Z

/test tekton-pipeline-unit-tests

eddycharly · 2020-04-28T09:31:49Z

/test tekton-pipeline-unit-tests

vdemeester

+:100:
/meow

config/101-podsecuritypolicy.yaml

tekton-robot · 2020-04-28T13:50:00Z

@vdemeester:

In response to this:

+:100:
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eddycharly · 2020-04-28T14:20:00Z

/hold
I feel like there are probably some superfluous labels

eddycharly · 2020-04-28T15:53:01Z

/hold cancel
I removed app.kubernetes.io/name and app.kubernetes.io/version when they had no value.

@vdemeester how about using app.kubernetes.io/version everywhere instead of pipeline.tekton.dev/release, triggers.tekton.dev/release, dashboard.tekton.dev/release, etc ?

eddycharly · 2020-04-28T15:58:03Z

/test tekton-pipeline-unit-tests

vdemeester · 2020-04-29T09:45:53Z

/hold cancel
I removed app.kubernetes.io/name and app.kubernetes.io/version when they had no value.

@vdemeester how about using app.kubernetes.io/version everywhere instead of pipeline.tekton.dev/release, triggers.tekton.dev/release, dashboard.tekton.dev/release, etc ?

yeah we could, but we will need to keep those (at least for a while) there as tools depend on them.

eddycharly · 2020-04-29T10:16:43Z

I know the dashboard depends on it, i am adding support for app.kubernetes.io/veersion there.
Any other tool ?

vdemeester · 2020-04-29T12:29:25Z

I know the dashboard depends on it, i am adding support for app.kubernetes.io/veersion there.
Any other tool ?

tkn
OpenShift Pipeline
most likely a bunch of other tools that we do not control 😝

We should add the new one, mark the old one as "deprecated" (in release note) and decide on a time where it gets removed (if we want to remove it 😛 )

eddycharly · 2020-05-14T08:04:11Z

/meow

tekton-robot · 2020-05-14T08:04:13Z

@eddycharly:

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

eddycharly · 2020-05-14T08:05:40Z

@vdemeester do you want to include changes from #2508 in this PR ?

vdemeester · 2020-05-14T09:21:19Z

@vdemeester do you want to include changes from #2508 in this PR ?

oh yeah we can 👍

eddycharly · 2020-05-14T10:11:04Z

Done, i took the objectSelector approach, hope it's ok for you.

vdemeester

/lgtm

tekton-robot · 2020-05-14T11:24:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot · 2020-05-14T11:25:57Z

This PR cannot be merged: expecting exactly one kind/ label

Available kind/ labels are:

kind/bug: Categorizes issue or PR as related to a bug.
kind/flake: Categorizes issue or PR as related to a flakey test
kind/cleanup: Categorizes issue or PR as related to cleaning up code, process, or technical debt.
kind/design: Categorizes issue or PR as related to design.
kind/documentation: Categorizes issue or PR as related to documentation.
kind/feature: Categorizes issue or PR as related to a new feature.
kind/misc: Categorizes issue or PR as a miscellaneuous one.

eddycharly · 2020-05-14T12:14:48Z

/kind feature

bobcatfish · 2020-06-15T14:10:06Z

NOTE: this will introduce a breaking change when trying to update deployments as label selectors have changed.

In future can we put this in the "release notes" section of the pull request description? That is what I was looking for when I made the 0.13 releases and I missed this breaking change :(

While looking into tektoncd#2816 we realized that tektoncd#2501 had indicated that this will require users to delete their Deployments but since the note wasn't in a release notes block it was missed (by me!) Adding this to the checklist might help contributors and reviewers be more aware. We also found that prow has a "release notes" plugin that might check this for us on PRs if we turn it on: https://github.com/kubernetes/test-infra/blob/128455dfd8003346afcdffa111d2298587f6fbf0/prow/plugins/releasenote/releasenote.go Co-authored-by: Sharon Jerop Kipruto <[email protected]>

While looking into #2816 we realized that #2501 had indicated that this will require users to delete their Deployments but since the note wasn't in a release notes block it was missed (by me!) Adding this to the checklist might help contributors and reviewers be more aware. We also found that prow has a "release notes" plugin that might check this for us on PRs if we turn it on: https://github.com/kubernetes/test-infra/blob/128455dfd8003346afcdffa111d2298587f6fbf0/prow/plugins/releasenote/releasenote.go Co-authored-by: Sharon Jerop Kipruto <[email protected]>

tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2020

tekton-robot requested review from abayer and dlorenc April 28, 2020 09:08

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 28, 2020

tekton-robot requested a review from vdemeester April 28, 2020 09:08

eddycharly force-pushed the k8s-labels branch 3 times, most recently from 78f359e to e6299f3 Compare April 28, 2020 11:42

eddycharly mentioned this pull request Apr 28, 2020

Add recommended k8s labels tektoncd/dashboard#1327

Merged

eddycharly force-pushed the k8s-labels branch from e6299f3 to db69523 Compare April 28, 2020 12:44

eddycharly changed the title ~~[WIP] Add recommended k8s labels~~ Add recommended k8s labels Apr 28, 2020

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2020

eddycharly mentioned this pull request Apr 28, 2020

Add recommended k8s labels tektoncd/triggers#556

Merged

vdemeester approved these changes Apr 28, 2020

View reviewed changes

config/101-podsecuritypolicy.yaml Outdated Show resolved Hide resolved

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2020

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2020

eddycharly force-pushed the k8s-labels branch 3 times, most recently from ba83238 to 9e23236 Compare April 28, 2020 15:47

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2020

eddycharly mentioned this pull request Apr 29, 2020

Improve get pipelines version func tektoncd/cli#947

Merged

eddycharly force-pushed the k8s-labels branch from 9e23236 to ee0a422 Compare May 14, 2020 09:31

add recommended k8s labels

486bc6b

eddycharly force-pushed the k8s-labels branch from ee0a422 to 486bc6b Compare May 14, 2020 09:32

vdemeester approved these changes May 14, 2020

View reviewed changes

tekton-robot assigned vdemeester May 14, 2020

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2020

tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 14, 2020

tekton-robot merged commit edc4539 into tektoncd:master May 14, 2020

eddycharly mentioned this pull request May 14, 2020

Is the config webhook working ? #2503

Closed

bobcatfish mentioned this pull request Jun 15, 2020

Tekton upgrade 0.11.3 -> 0.13.2 #2816

Closed

bobcatfish mentioned this pull request Jun 15, 2020

Add checklist item for release notes ✅ #2820

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add recommended k8s labels #2501

Add recommended k8s labels #2501

eddycharly commented Apr 28, 2020 •

edited

Loading

eddycharly commented Apr 28, 2020

eddycharly commented Apr 28, 2020

eddycharly commented Apr 28, 2020

vdemeester left a comment

tekton-robot commented Apr 28, 2020

eddycharly commented Apr 28, 2020

eddycharly commented Apr 28, 2020

eddycharly commented Apr 28, 2020

vdemeester commented Apr 29, 2020

eddycharly commented Apr 29, 2020

vdemeester commented Apr 29, 2020

eddycharly commented May 14, 2020

tekton-robot commented May 14, 2020

eddycharly commented May 14, 2020

vdemeester commented May 14, 2020

eddycharly commented May 14, 2020

vdemeester left a comment

tekton-robot commented May 14, 2020

tekton-robot commented May 14, 2020

eddycharly commented May 14, 2020

bobcatfish commented Jun 15, 2020

Add recommended k8s labels #2501

Add recommended k8s labels #2501

Conversation

eddycharly commented Apr 28, 2020 • edited Loading

eddycharly commented Apr 28, 2020

eddycharly commented Apr 28, 2020

eddycharly commented Apr 28, 2020

vdemeester left a comment

Choose a reason for hiding this comment

tekton-robot commented Apr 28, 2020

eddycharly commented Apr 28, 2020

eddycharly commented Apr 28, 2020

eddycharly commented Apr 28, 2020

vdemeester commented Apr 29, 2020

eddycharly commented Apr 29, 2020

vdemeester commented Apr 29, 2020

eddycharly commented May 14, 2020

tekton-robot commented May 14, 2020

eddycharly commented May 14, 2020

vdemeester commented May 14, 2020

eddycharly commented May 14, 2020

vdemeester left a comment

Choose a reason for hiding this comment

tekton-robot commented May 14, 2020

tekton-robot commented May 14, 2020

eddycharly commented May 14, 2020

bobcatfish commented Jun 15, 2020

eddycharly commented Apr 28, 2020 •

edited

Loading