Issue 1880: Adds ability to disable certificate validation in pullrequest resource

[dibbles]

Changes

Fixes Issue #1880 by adding the ability to disable certificate validation in the client interacting with the git server performing actions related to the use of the pipeline resource of type pullrequest.

To disable, user specifies sslVerify parameter in their resource with value set to "false". Value is true by default.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task to build and release this image.

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Users are now able to disable certificate validation in the client that is used to perform actions for the pull request pipeline resource.  To disable certificate validation, the user specifies the sslVerify parameter in their pipeline resource with the value set to "false".  Value is true by default.

[dibbles]

/test pull-tekton-pipeline-integration-tests

[chmouel]

/lgtm

[ghost]

/cc @wlynch

[ghost]

Looks like lint errors:

I0116 15:45:09.958] ===============================
I0116 15:45:09.958] ==== RUNNING GOLANGCI-LINT ====
I0116 15:45:09.958] ===============================
I0116 15:45:55.656] pkg/apis/pipeline/v1alpha1/pull_request_resource.go:67:3: ifElseChain: rewrite if-else to switch statement (gocritic)
I0116 15:45:55.657] 		if strings.EqualFold(param.Name, "URL") {
I0116 15:45:55.658] 		^
I0116 15:45:55.658] pkg/pullrequest/scm.go:28: File is not `goimports`-ed (goimports)
I0116 15:45:55.658] 	"crypto/tls"
I0116 15:45:55.659] pkg/pullrequest/scm_test.go:20: File is not `goimports`-ed (goimports)
I0116 15:45:55.659] 	"go.uber.org/zap"
I0116 15:45:55.660] 	"go.uber.org/zap/zaptest/observer"
I0116 15:45:55.660] cmd/pullrequest-init/main.go:21: File is not `goimports`-ed (goimports)
I0116 15:45:55.660] 	"fmt"
I0116 15:45:55.661] pkg/pullrequest/scm.go:95: G402: TLS InsecureSkipVerify may be true. (gosec)
I0116 15:45:55.661] 					TLSClientConfig: &tls.Config{InsecureSkipVerify: !sslVerify},
I0116 15:45:55.662] pkg/pullrequest/scm.go:102: G402: TLS InsecureSkipVerify may be true. (gosec)
I0116 15:45:55.662] 				TLSClientConfig: &tls.Config{InsecureSkipVerify: !sslVerify},
I0116 15:45:55.662] pkg/pullrequest/scm.go:148: G402: TLS InsecureSkipVerify may be true. (gosec)
I0116 15:45:55.663] 					TLSClientConfig: &tls.Config{InsecureSkipVerify: !sslVerify},

[dibbles]

Linter fixes added ..... added ignore for TLS linter issue as the ability to run insecure is exactly what this code provides and I think the G402 is just stipulating that this could be a security problem.

[ghost]

i have one more comment but otherwise this code is ready to go imo

[ghost]

/lgtm

[vdemeester]

/meow

[tekton-robot]

@vdemeester:

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment