Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct "outputs.resources.%s.path" #1854

Merged

Conversation

vincent-pli
Copy link
Member

Fix issue #1642
If the targetpath is AP, outputs.resources.%s.path is exactly the targetpath, or it should be: /workspace/ + targetpath.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Describe any user facing changes here, or delete this block.

Examples of user facing changes:
- API changes
- Bug fixes
- Any changes in behavior

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Jan 13, 2020
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 13, 2020
If the `targetpath` is AP, `outputs.resources.%s.path is exactly the `targetpath`, or it should be: `/workspace/` + `targetpath`.
@vincent-pli vincent-pli force-pushed the correct-outputs.resources.%s.path branch from 5d69a54 to 0061d36 Compare January 13, 2020 02:42
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2020
@ghost
Copy link

ghost commented Jan 13, 2020

This looks good to me but now I am wondering - should /workspace be replaced with whatever the step's workingDir field is set to (see this related issue that came up very recently)?

Either way I think this is good to merge now and we can correct the workingDir behaviour in a follow up when #1836 is resolved?

/lgtm

@tekton-robot tekton-robot assigned ghost Jan 13, 2020
@ghost
Copy link

ghost commented Jan 13, 2020

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2020
@tekton-robot tekton-robot merged commit 00e3b95 into tektoncd:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants