Mark task as failed if OOMKilled.

[bigkevmcd]

Changes

Fix for #1806 - identifies OOMKilled as failure (despite exite code 0)

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

Reviewer Notes

If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.

Release Notes

Fix for #1806 fail tasks that are killed with OOM.

[tekton-robot]

Hi @bigkevmcd. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[chmouel]

/ok-to-test

[chmouel]

I think we may want to document this behaviour[1]? I'd say probably in taskruns.md

[1] exitCode==0 + OOMKilled == FAILURE

[chmouel]

/lgtm

[vdemeester]

/lgtm
/meow

thanks @bigkevmcd

[tekton-robot]

@vdemeester:

In response to this:

/lgtm
/meow

thanks @bigkevmcd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment