Allow keeping namespaces after running tests for investigation #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we have a failure, the tearDown function would delete the 'arendelle' namespace with no way to investigate. Add an environment variable TEST_KEEP_NAMESPACES to disable the namespace deletion. This could be useful for successful run too, for further investigation if needed. Signed-off-by: Chmouel Boudjnah <[email protected]>
googlebot
added
the
cla: yes
tekton-robot
added
the
size/S
|
/test pull-tekton-pipeline-integration-tests |
|
I can make it to work with the -X define ie |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ImJasonH The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
This is such a good idea!! 👍👍👍 Thanks @chmouel :D ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When we have a failure, the tearDown function would delete the randomly created 'arendelle'
namespace with no way to investigate.
Add an environment variable
TEST_KEEP_NAMESPACESto disable the namespacedeletion. This could be useful for successful run too, for further investigation
if needed.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
NA
Release Notes
NA