Add read-only copy of pull request object in resource output. #1685
Conversation
googlebot
added
the
cla: yes
tekton-robot
added
the
size/M
|
/test pull-tekton-pipeline-integration-tests |
| @@ -0,0 +1 @@ | |||
| {"Ref":"master","Sha":"723b9a9d560bdf4dc8fc6f697d53f662d3454ac8","Repo":{"ID":"146641150","Namespace":"tektoncd","Name":"pipeline","FullName":"tektoncd/pipeline","Perm":{"Pull":false,"Push":false,"Admin":false},"Branch":"master","Private":false,"Clone":"https://github.com/tektoncd/pipeline.git","CloneSSH":"[email protected]:tektoncd/pipeline.git","Link":"https://github.com/tektoncd/pipeline","Created":"2018-08-29T18:21:55Z","Updated":"2019-12-04T17:26:42Z"}} | |||
There was a problem hiding this comment.
I see a lot of JSON files under pullrequest-init/example...is this intentional?
There was a problem hiding this comment.
Yup! Instead of embedding each payload in the resource docs, I figured it'd be more useful to include a complete example.
There was a problem hiding this comment.
nit: we could use ./testdata folder if we want to use those for tests (it's a special folder in the go world)
There was a problem hiding this comment.
yeah along the same lines, if this is just for documentation purposes, maybe there is a better folder than inside cmd. And if its for tests, maybe a testdata. But this is a pretty minor thing so that should not hold up this PR!
Also fixes minor permission issue (rwx -> rw for most files). Initial fix to grant users access to the rest of the PR information. This file is read-only so that we can use the subresources (e.g. labels, comments, etc.) as the source of truth. As a follow up, we may want to consider pruning this from the PR output. I wasn't sure how to do this without forking the scm.PullRequest resource. I'd like to avoid this in order to make updates to the upstream scm library as easy as possible. This should be fine for now to get into for 0.9.1, and we can iterate on this as needed.
tekton-robot
added
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dibyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
Thanks! We now need to cherry pick this one on branchv0.9.x, right? |
Changes
Initial fix to grant users access to the rest of the PR information.
This file is read-only so that we can use the subresources (e.g. labels,
comments, etc.) as the source of truth.
As a follow up, we may want to consider pruning unneeded fields from the PR output.
I wasn't sure how to do this without forking the scm.PullRequest
resource, and I'd like to avoid this in order to make updates from the
upstream scm library as easy/minimal as possible. This should be fine for now to
get into for 0.9.1, and we can iterate on this as needed.
Fixes #1681
/cc @afrittoli
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Double check this list of stuff that's easy to miss:
cmddir, please updatethe release Task to build and release this image.
Reviewer Notes
If API changes are included, additive changes must be approved by at least two OWNERS and backwards incompatible changes must be approved by more than 50% of the OWNERS, and they must first be added in a backwards compatible way.
Release Notes