Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tests for array indexing validation functions #6278

Closed
Yongxuanzhang opened this issue Mar 2, 2023 · 1 comment · Fixed by #6281
Closed

Add missing tests for array indexing validation functions #6278

Yongxuanzhang opened this issue Mar 2, 2023 · 1 comment · Fixed by #6281

Comments

@Yongxuanzhang
Copy link
Member

From #6180, we found out that there are some cases not covered before when introducing matrix support. We could add tests to improve the coverage.
@Yongxuanzhang
Copy link
Member Author

/assing

@Yongxuanzhang Yongxuanzhang mentioned this issue Mar 2, 2023
Merged
7 tasks
Yongxuanzhang added a commit to Yongxuanzhang/pipeline that referenced this issue Mar 2, 2023
@Yongxuanzhang
add missing test cases for matrix params array indexing validation
2e93e74 
This commit adds missing test cases for matrix params array indexing
validation. The array indexing for matrix params is supported in
previous PR but test cases are missing.

Closes tektoncd#6278

Signed-off-by: Yongxuan Zhang [email protected]
@Yongxuanzhang Yongxuanzhang mentioned this issue Mar 2, 2023
Merged
7 tasks
Yongxuanzhang added a commit to Yongxuanzhang/pipeline that referenced this issue Mar 2, 2023
@Yongxuanzhang
add missing test cases for matrix params array indexing validation
8886484 
This commit adds missing test cases for matrix params array indexing
validation. The array indexing for matrix params is supported in
previous PR but test cases are missing.

Closes tektoncd#6278

Signed-off-by: Yongxuan Zhang [email protected]
tekton-robot pushed a commit that referenced this issue Mar 7, 2023
@Yongxuanzhang @tekton-robot
add missing test cases for matrix params array indexing validation
0c91334 
This commit adds missing test cases for matrix params array indexing
validation. The array indexing for matrix params is supported in
previous PR but test cases are missing.

Closes #6278

Signed-off-by: Yongxuan Zhang [email protected]
EmmaMunley pushed a commit to EmmaMunley/pipeline that referenced this issue Mar 9, 2023
@Yongxuanzhang @EmmaMunley
add missing test cases for matrix params array indexing validation
9539aaf 
This commit adds missing test cases for matrix params array indexing
validation. The array indexing for matrix params is supported in
previous PR but test cases are missing.

Closes tektoncd#6278

Signed-off-by: Yongxuan Zhang [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add missing test cases for matrix params array indexing validation Yongxuanzhang/pipeline
1 participant
@Yongxuanzhang