Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the storybook group with 4 updates #2990

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 16, 2023

Bumps the storybook group with 4 updates: @storybook/addon-storysource, @storybook/addons, @storybook/react and @storybook/theming.

Updates @storybook/addon-storysource from 7.0.25 to 7.0.27

Release notes

Sourced from @​storybook/addon-storysource's releases.

v7.0.27

7.0.27

v7.0.26

7.0.26

Changelog

Sourced from @​storybook/addon-storysource's changelog.

7.0.27

7.0.26

Commits

Updates @storybook/addons from 7.0.25 to 7.0.27

Release notes

Sourced from @​storybook/addons's releases.

v7.0.27

7.0.27

v7.0.26

7.0.26

Changelog

Sourced from @​storybook/addons's changelog.

7.0.27

7.0.26

Commits

Updates @storybook/react from 7.0.25 to 7.0.27

Release notes

Sourced from @​storybook/react's releases.

v7.0.27

7.0.27

v7.0.26

7.0.26

Changelog

Sourced from @​storybook/react's changelog.

7.0.27

7.0.26

Commits

Updates @storybook/theming from 7.0.25 to 7.0.27

Release notes

Sourced from @​storybook/theming's releases.

v7.0.27

7.0.27

v7.0.26

7.0.26

Changelog

Sourced from @​storybook/theming's changelog.

7.0.27

7.0.26

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

Bumps the storybook group with 4 updates: [@storybook/addon-storysource](https://github.com/storybookjs/storybook/tree/HEAD/code/addons/storysource), [@storybook/addons](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/addons), [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/react) and [@storybook/theming](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/theming).


Updates `@storybook/addon-storysource` from 7.0.25 to 7.0.27
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v7.0.27/code/addons/storysource)

Updates `@storybook/addons` from 7.0.25 to 7.0.27
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/v7.0.27/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v7.0.27/code/lib/addons)

Updates `@storybook/react` from 7.0.25 to 7.0.27
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v7.0.27/code/renderers/react)

Updates `@storybook/theming` from 7.0.25 to 7.0.27
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v7.0.27/code/lib/theming)

---
updated-dependencies:
- dependency-name: "@storybook/addon-storysource"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: storybook
- dependency-name: "@storybook/addons"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: storybook
- dependency-name: "@storybook/react"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: storybook
- dependency-name: "@storybook/theming"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: storybook
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added area/dependency Issues or PRs related to dependency changes dependencies Used by dependabot - identifies all PRs created by dependabot javascript Pull requests that update Javascript code kind/misc Categorizes issue or PR as a miscellaneuous one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Jul 16, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 16, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign skaegi after the PR has been reviewed.
You can assign the PR to them by writing /assign @skaegi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot
Copy link
Contributor

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member

Storybook 7.1 has just been released so we'll update to that instead. However, after the auto update (npx storybook@latest upgrade) we see a few issues:

  • automigrations fail during the upgrade process with the following error:
    🔎 checking possible migrations..
    [Storybook automigrate] ❌ Failed trying to evaluate .storybook/main.js with the following error: mainConfigMatches is not iterable
    Please fix the error and try again.
    
  • npm run storybook fails with a related error:
    ERR! TypeError: mainConfigMatches is not iterable
    ERR!     at validateConfigurationFiles (~/workspace/github.com/tektoncd/dashboard/node_modules/@storybook/core-common/dist/index.js:6:1094)
    ERR!     at async loadMainConfig (~/workspace/github.com/tektoncd/dashboard/node_modules/@storybook/core-common/dist/index.js:19:6679)
    ERR!     at async buildDevStandalone (~/workspace/github.com/tektoncd/dashboard/node_modules/@storybook/core-server/dist/index.js:128:1102)
    ERR!     at async withTelemetry (~/workspace/github.com/tektoncd/dashboard/node_modules/@storybook/core-server/dist/index.js:113:3659)
    ERR!     at async dev (~/workspace/github.com/tektoncd/dashboard/node_modules/@storybook/cli/dist/generate.js:435:401)
    ERR!     at async Command.<anonymous> (~/workspace/github.com/tektoncd/dashboard/node_modules/@storybook/cli/dist/generate.js:437:225)
    
  • it also introduces a version of semver that's currently being flagged by npm audit

Let's give it a few days to settle and report any remaining issues.

@AlanGreene
Copy link
Member

AlanGreene commented Jul 19, 2023

Update: removing an override we had in place for glob as a dependency of @storybook/core-common allows Storybook to start.

However, navigating between stories intermittently results in the following error:

ReferenceError: Cannot access '__WEBPACK_DEFAULT_EXPORT__' before initialization
    at Module.default (http://localhost:5000/src_containers_ListPageLayout_ListPageLayout_stories_js.iframe.bundle.js:11173:42)
    at Module.default (http://localhost:5000/src_containers_ListPageLayout_ListPageLayout_stories_js.iframe.bundle.js:11391:106)
    at registerExportsForReactRefresh (http://localhost:5000/vendors-node_modules_pmmmwh_react-refresh-webpack-plugin_client_ErrorOverlayEntry_js-node_mod-f37a25.iframe.bundle.js:5508:36)
    at Object.executeRuntime (http://localhost:5000/vendors-node_modules_pmmmwh_react-refresh-webpack-plugin_client_ErrorOverlayEntry_js-node_mod-f37a25.iframe.bundle.js:5543:3)
    at $ReactRefreshModuleRuntime$ (http://localhost:5000/src_containers_ListPageLayout_ListPageLayout_stories_js.iframe.bundle.js:11431:34)
    at ./src/containers/ListPageLayout/index.js (http://localhost:5000/src_containers_ListPageLayout_ListPageLayout_stories_js.iframe.bundle.js:11444:2)
    at options.factory (http://localhost:5000/runtime~main.iframe.bundle.js:682:31)
    at __webpack_require__ (http://localhost:5000/runtime~main.iframe.bundle.js:28:33)
    at fn (http://localhost:5000/runtime~main.iframe.bundle.js:339:21)
    at ./src/containers/index.js (http://localhost:5000/src_containers_ListPageLayout_ListPageLayout_stories_js.iframe.bundle.js:19425:74)

Refreshing the page results in the story being displayed correctly, but navigating away and back again often reproduces the issue.

Investigation needed…

Update: seems to be specific to navigating to one of the 'Containers' stories.

Also seeing some intermittent loading issues when navigating quickly between other stories, gets stuck in the loading state until page refresh.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 23, 2023

Looks like these dependencies are updatable in another way, so this is no longer needed.

@dependabot dependabot bot closed this Jul 23, 2023
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/storybook-5bab89ae0d branch July 23, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes dependencies Used by dependabot - identifies all PRs created by dependabot javascript Pull requests that update Javascript code kind/misc Categorizes issue or PR as a miscellaneuous one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants