-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable v1 API use by default #2976
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Flip the default value of the v1 API toggle on the settings page. Tekton Pipelines v0.44 serves v1 and is the minimum supported Pipelines release for the latest Dashboard release so it is now safe to enable this by default. A future release will remove the toggle entirely, but that won't be until some time after Pipelines have deprecated and removed the v1beta1 resources. Update Jest config to load the real YAML file instead of a mock object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Flip the default value of the v1 API toggle on the settings page. Tekton Pipelines v0.44 serves v1 and is the minimum supported Pipelines release for the latest Dashboard release so it is now safe to enable this by default.
A future release will remove the toggle entirely, but that won't be until some time after Pipelines have deprecated and removed the v1beta1 resources.
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes