Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable v1 API use by default #2976

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Conversation

AlanGreene
Copy link
Member

Changes

Flip the default value of the v1 API toggle on the settings page. Tekton Pipelines v0.44 serves v1 and is the minimum supported Pipelines release for the latest Dashboard release so it is now safe to enable this by default.

A future release will remove the toggle entirely, but that won't be until some time after Pipelines have deprecated and removed the v1beta1 resources.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Switch the default value of the v1 CRD toggle on the settings page from off to on. This means that the Dashboard will request and display v1 resources from Tekton Pipelines by default unless the user has previously changed this setting.
Action required: If you wish to opt-out of this change, you can turn off the toggle on the settings page. Note: a future Dashboard release will remove this toggle but this won't happen until some time after Tekton Pipelines have deprecated and removed the v1beta1 resources.

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 6, 2023
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 6, 2023
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2023
Flip the default value of the v1 API toggle on the settings page.
Tekton Pipelines v0.44 serves v1 and is the minimum supported Pipelines
release for the latest Dashboard release so it is now safe to enable
this by default.

A future release will remove the toggle entirely, but that won't be until
some time after Pipelines have deprecated and removed the v1beta1 resources.

Update Jest config to load the real YAML file instead of a mock object.
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 6, 2023
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit b0e6ccf into tektoncd:main Jul 7, 2023
3 checks passed
@AlanGreene AlanGreene deleted the v1_default branch July 7, 2023 09:43
AlanGreene added a commit to AlanGreene/dashboard that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants