Skip to content

Commit

Permalink
Add missing API root for external logs requests
Browse files Browse the repository at this point in the history
Somehow the external logs APIs in the client never used the API
root when constructing the URL. This means that if the Dashboard
is deployed at a non-root path, the requests never made it to
the logs proxy.

Update the external logs URL util to include the API root in the
same manner as we already do for all other APIs.
  • Loading branch information
AlanGreene committed Sep 16, 2024
1 parent 6c6b64e commit 4257270
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/api/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export function getExternalLogURL({
if (queryString) {
queryString = `?${queryString}`;
}
return `${externalLogsURL}/${namespace}/${podName}/${container}${queryString}`;
return `${getAPIRoot({ isDashboardAPI: true })}${externalLogsURL}/${namespace}/${podName}/${container}${queryString}`;
}

export function getPodLogURL({ container, name, namespace, follow }) {
Expand Down

0 comments on commit 4257270

Please sign in to comment.