Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analytics feature #14

Merged
merged 14 commits into from
Nov 30, 2021
Merged

analytics feature #14

merged 14 commits into from
Nov 30, 2021

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented Nov 23, 2021 •
edited
Loading

  • moving to domain-driven design approach
  • using proper Redis pipeline
  • properly working analytics package
  • working test for analytics package
  • secure environment variables requirements on main.go
  • updated environment variables on production machine

@codecov
Copy link

codecov bot commented Nov 30, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@556a96f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #14   +/-   ##
=========================================
  Coverage          ?   66.55%           
=========================================
  Files             ?       10           
  Lines             ?      311           
  Branches          ?        0           
=========================================
  Hits              ?      207           
  Misses            ?       81           
  Partials          ?       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 556a96f...b0249a0. Read the comment docs.

@aldy505 aldy505 marked this pull request as ready for review November 30, 2021 05:36
@aldy505 aldy505 requested review from a user and elianiva November 30, 2021 05:36
elianiva
elianiva reviewed Nov 30, 2021
View reviewed changes
analytics/incr.go
"github.com/go-redis/redis/v8"
)

func (d *Dependency) IncrementUsrDB(ctx context.Context, users []UserMap) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kenapa Usr bukan User?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well bcs I'm this knd of prsn

@aldy505 aldy505 merged commit e5baf72 into master Nov 30, 2021
@aldy505 aldy505 deleted the feat/analytics branch November 30, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elianiva elianiva elianiva left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aldy505 @elianiva