Skip to content

fix(ci): fix default value for fail_on_warn to be a boolean - #80

Merged
tehw0lf merged 1 commit into
mainfrom
fix/dast-scan
Jun 8, 2026
Merged

fix(ci): fix default value for fail_on_warn to be a boolean#80
tehw0lf merged 1 commit into
mainfrom
fix/dast-scan

Conversation

@tehw0lf

@tehw0lf tehw0lf commented Jun 8, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores
    • Corrected security scan workflow input default type from string to boolean for improved parameter consistency.

@tehw0lf
tehw0lf enabled auto-merge (squash) June 8, 2026 08:53
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6a6fbde2-75d7-4c46-968f-4683a05f8323

📥 Commits

Reviewing files that changed from the base of the PR and between 52bf799 and 1192f8f.

📒 Files selected for processing (1)
  • .github/workflows/security-scan-dast.yml

📝 Walkthrough

Walkthrough

The PR corrects a type mismatch in the DAST security scan workflow. The fail_on_warn input default is updated from a string value to a boolean value, ensuring the correct type is passed to the downstream ZAP security action when the parameter is not explicitly provided.

Changes

Security Scan Workflow Update

Layer / File(s) Summary
Fix fail_on_warn default type
.github/workflows/security-scan-dast.yml
The fail_on_warn workflow input default is corrected from string "false" to boolean false, aligning the type with downstream ZAP action parameter expectations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A boolean hops where strings once stood,
false now wears its true-blue hood,
ZAP's fail_action grins with glee,
Type-matched workflows dance so free! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dast-scan

Comment @coderabbitai help to get the list of available commands and usage tips.

@tehw0lf
tehw0lf merged commit 0e551aa into main Jun 8, 2026
2 of 3 checks passed
@tehw0lf
tehw0lf deleted the fix/dast-scan branch June 8, 2026 08:54
@coderabbitai coderabbitai Bot mentioned this pull request Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant