Skip to content

Use multi-run median for lighthouse performance score #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tehw0lf merged 1 commit into from
Jul 13, 2026
Merged

Use multi-run median for lighthouse performance score #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/lighthouse-scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ on:
default: 80
required: false
type: number
num_runs:
description: "number of lighthouse runs per url; median is used (reduces CI runner jitter/flakiness)"
default: 3
required: false
type: number
runner:
description: "workflow-runner"
default: "ubuntu-latest"
Expand Down Expand Up @@ -108,6 +113,7 @@ jobs:
with:
urls: ${{ steps.urls.outputs.urls }}
configPath: .lighthouserc.json
numberOfRuns: ${{ inputs.num_runs }}

@coderabbitai coderabbitai Bot Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

ref="3e7e23fb74242897f95c0ba9cabad3d0227b9b18"
curl -fsSL "https://raw.githubusercontent.com/treosh/lighthouse-ci-action/${ref}/action.yml" |
  grep -E '(^| )runs:|numberOfRuns'

Repository: tehw0lf/workflows

Length of output: 169

Use runs here.
numberOfRuns isn’t an input accepted by treosh/lighthouse-ci-action, so the workflow input is ignored and the run count won’t change.

Proposed fix 
-          numberOfRuns: ${{ inputs.num_runs }}
+          runs: ${{ inputs.num_runs }}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
numberOfRuns: ${{ inputs.num_runs }}
runs: ${{ inputs.num_runs }}
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/lighthouse-scan.yml at line 116, Update the
treosh/lighthouse-ci-action configuration to use the runs input instead of
numberOfRuns, while preserving the existing inputs.num_runs value so the
workflow’s requested run count is applied.

uploadArtifacts: true
temporaryPublicStorage: true

Expand Down
Loading