Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove whitespace from bytes encoded xml strings #1037

Merged
merged 1 commit into from
May 11, 2024

Conversation

tefra
Copy link
Owner

@tefra tefra commented May 11, 2024

📒 Description

At some point we enabled strict bytes parsing and in a lot of samples people/libraries love to split the values into multiple lines which now fails in xsdata. Let's ensure no whitespace exists before we parse the actual value

Resolves #xxxx

🔗 What I've Done

Write a description of the steps taken to resolve the issue

💬 Comments

A place to write any comments to the reviewer.

🛫 Checklist

Copy link

sonarcloud bot commented May 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d561ff5) to head (a5f36fa).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1037   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          115       115           
  Lines         9282      9284    +2     
  Branches      2190      2190           
=========================================
+ Hits          9282      9284    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tefra tefra merged commit 3713c6a into main May 11, 2024
15 checks passed
@tefra tefra deleted the remove-whitespace-bytes-converter branch May 11, 2024 14:18
skinkie pushed a commit to skinkie/xsdata that referenced this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant